-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
general performance issue #11
Comments
to address another comment in the source, this probably means
|
|
Ok, good learnings + thoughts. Comments:
Just to confirm I that I understand this: you expect we can get efficiencies from batching at the NFS protocol layer. I believe we already have the Nagle algorithm in TCP layer (though now that I think about it I'm not sure whether we want that - maybe we just do all of the batching ourselves).
Ah, yes, we should probably experiment with this. We definitely need to renumber these because this seems like low-hanging fruit. I'll want to make sure that we have all of these changes flagged so that we can measure and compare performance under different approaches. |
right. just like nagle. nagle though is probably going to be a little blind. in particular it flushes with a timer and not with an explicit sync.and i think(?) the size threshold is lower than the tcp mss. sure wrp flags. dynamic api is preferable to compile time. |
oh right, nagle in this case wont help and in fact might be hurting because we block waiting for the remote response on each write
|
note that pipelining segmented transfers might not get us anything, since i'm pretty sure sqlite will max out at a page size. if thats the <= segment size then it kind of doesn't matter (for this application) |
optimizations we are consider are
note that (2) might obviate (1). (1) may in fact be necessary for correctness if the server evaluates out of order
The text was updated successfully, but these errors were encountered: