-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
UI design system needs to be removed for the code optimization #75
Comments
|
are we using all these components in our project? Which all components are we using from this? |
This should not be an issue. NextJS automatically removes unused components from the bundle during tree-shaking. So we can live with that, and as @singhlify mentions, we probably might need these components in future. |
This is an issue for sure. Having code which is "may be" need/use in future is just adding junk or unnecessary code in the code-base. Always keep the code which is required now. When the "future" will come then can import/add the required code. Secondly, I would sill prefer a design system over this shadcn/ui. Reasons are:
|
shadcn/ui is a use what you need as you go type of library, it runs on the philosophy of you own your code and components, which is the reason behind all the components being defined in the source code instead of a library import. To answer your concerns:
On the other hand, if we want to use some other component library, here are some Tailwind based libraries:
These are the ones I know about. |
Describe the bug
Currently in the code there is UI folder with ui components and most of them are not getting used anywhere in the code.
this is going to create the code size, and cause performance issues.
Design system should be implemented in a way that only required component should be imported when required.
To Reproduce
Steps to reproduce the behavior:
Expected behavior
Design system should be implemented in a way that only required component should be imported when required.
Screenshots
Desktop (please complete the following information):
Smartphone (please complete the following information):
Additional context
Add any other context about the problem here.
The text was updated successfully, but these errors were encountered: