Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code improvements Suggestions [WIP] #74

Open
Neha opened this issue Jun 13, 2024 · 0 comments
Open

Code improvements Suggestions [WIP] #74

Neha opened this issue Jun 13, 2024 · 0 comments
Assignees

Comments

@Neha
Copy link
Contributor

Neha commented Jun 13, 2024

Describe the bug
This would be a list of code improvements to do in the code:

  1. Create a reusable component of "form". "Enter your email" section is required more than 2 places.
  2. Homepage -> Previous talk section can be break into small component. map logic should be outside JSX as a separate function
  3. Homepage -> Form on homepage should be a separate component
  4. Homepage -> Some content is hard coded and some is coming from config. Need to sort this out
  5. Header component -> Requires code optimizations. The HTML can be optimize by removing extra DIV and Make 3 different components: LOGO, Nav, and Register Button.
  6. Footer: map should be outside JSX

A few issues can be taken care with this issue:

#72
#63
#58

To Reproduce
Steps to reproduce the behavior:

  1. Go to '...'
  2. Click on '....'
  3. Scroll down to '....'
  4. See error

Expected behavior
A clear and concise description of what you expected to happen.

Screenshots
If applicable, add screenshots to help explain your problem.

Desktop (please complete the following information):

  • OS: [e.g. iOS]
  • Browser [e.g. chrome, safari]
  • Version [e.g. 22]

Smartphone (please complete the following information):

  • Device: [e.g. iPhone6]
  • OS: [e.g. iOS8.1]
  • Browser [e.g. stock browser, safari]
  • Version [e.g. 22]

Additional context
Add any other context about the problem here.

Neha added a commit that referenced this issue Jun 15, 2024
code improvements of header, and layouts
@Neha Neha mentioned this issue Jun 18, 2024
18 tasks
@Neha Neha self-assigned this Jun 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant