Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore -> Add Unit Test Cases #25

Open
ekas opened this issue Oct 29, 2023 · 4 comments
Open

Chore -> Add Unit Test Cases #25

ekas opened this issue Oct 29, 2023 · 4 comments
Labels
chore help wanted Extra attention is needed

Comments

@ekas
Copy link
Member

ekas commented Oct 29, 2023

No description provided.

@ekas ekas converted this from a draft issue Oct 29, 2023
@ekas ekas added help wanted Extra attention is needed chore labels Oct 29, 2023
@ekas ekas added this to the JSLovers ver1.0 milestone Oct 29, 2023
@Neha
Copy link
Contributor

Neha commented Nov 6, 2023

@ekas do we want just the initial setup in this issue?

We should encourage every developer to add test-cases with their PRs

@ekas
Copy link
Member Author

ekas commented Nov 6, 2023

Yes, Just the initial setup. And you are right, we could ask developers to add their test-cases.

@mukeshyadav
Copy link

@ekas @Neha May I take this on? Here's what I plan to do:

  1. Introduce react-testing-library.
  2. Add some tests to give other developers an idea of how to start.
  3. Implement a pre-commit hook to ensure that developers can't push code without adding tests, or bypass the tests if not required by using specific comments inside the PR, e.g., <!-- Test not required -->.

If you have any other suggestions, please let me know.

@Neha
Copy link
Contributor

Neha commented Jul 27, 2024

@mukeshyadav thank you for your inputs.

  1. yes. 100%
  2. yes. I will create issues to add a few test-cases
  3. we can do this after we have a few test-cases ready.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore help wanted Extra attention is needed
Development

No branches or pull requests

3 participants