Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

jqxgrid: columngrouprenderer not respected with rtl=true and closeablegroups=true #756

Closed
jjamid opened this issue Dec 19, 2024 · 1 comment

Comments

@jjamid
Copy link

jjamid commented Dec 19, 2024

Describe the bug

When using jqxgrid with rtl=true together with closeablegroups=true and columngrouprenderer, it does not result in a custom text.
It does works with rtl=false.

Reason:
In file 'jqwidgets/modules/jqxgrid.js' in function '_rendergroupcolumn' the correct value is set by this code

if (this.groupcolumnrenderer != null) {
                group[0].innerHTML = this.groupcolumnrenderer(text);
                ...
}

But later overriden by this code which ignores the content of group[0].innerHTML (the result of groupcolumnrenderer) and uses the initial value 'text' instead.

if (this.rtl) {
   group[0].innerHTML = '<a style="float: right;" href="#">' + text + '</a>';
}

To Reproduce
Steps to reproduce the behavior:

  1. set rtl to true
  2. set closeablegroups to true
  3. define a custom groupcolumnrenderer that alters the default text
  4. group by a column
  5. the text displayed in the header shows the default text instead of the custom one

Expected behavior
That groupcolumnrenderer be respected for both rtl=true and rtl=false

Screenshots
image

Desktop (please complete the following information):

  • Windows
  • Edge
  • Version 131
@bmarkov
Copy link
Collaborator

bmarkov commented Jan 19, 2025

fixed for next version. The bug fix will be included in this month's release.

@bmarkov bmarkov closed this as completed Jan 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants