Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make watch-ui fails #2

Open
sogaiu opened this issue Nov 30, 2019 · 4 comments
Open

make watch-ui fails #2

sogaiu opened this issue Nov 30, 2019 · 4 comments
Labels
bug Something isn't working

Comments

@sogaiu
Copy link

sogaiu commented Nov 30, 2019

Was trying to test the latest code, and having encountered an issue there [1], tried to get things running from source.

On a fresh clone of the repository (7c191af), in the cloned directory, I get:

$ make watch-ui
npx shadow-cljs watch app
npx: installed 90 in 5.905s
shadow-cljs - config: /home/user/Desktop/src/clograms.fresh/shadow-cljs.edn  cli version: 2.4.10  node: v8.16.0
shadow-cljs - starting via "clojure"
Execution error at shadow.build/eval9831$loading (build.clj:1).
Unable to resolve spec: :clojure.core.specs.alpha/args+body

Full report at:
/tmp/clojure-4309429650306985496.edn
make: *** [Makefile:16: watch-ui] Error 1

zipped /tmp/clojure-4309429650306985496.edn:

clojure-4309429650306985496.edn.zip

Am I doing something wrong or missing something?

FWIW, this is using a Linux distribution.

[1] May report that later after trying to resolve this issue.

@sogaiu
Copy link
Author

sogaiu commented Nov 30, 2019

On a side note, I don't see a package-lock.json (or a yarn lock file) as part of the repository. I think this may tend to lead to different environments making things less reproducible.

What do you think of the idea of adding an appropriate lock file to the repository?

@sogaiu
Copy link
Author

sogaiu commented Nov 30, 2019

After removing .shadow-cljs and node_modules, I added shadow-cljs 2.8.55 to the devDependencies of package.json, did npm install, and now I get:

$ make watch-ui
npx shadow-cljs watch app
shadow-cljs - config: /home/user/Desktop/src/clograms.fresh/shadow-cljs.edn  cli version: 2.8.55  node: v8.16.0
shadow-cljs - starting via "clojure"
Syntax error (ArrayIndexOutOfBoundsException) compiling fn* at (shadow/cljs/devtools/server/repl_impl.clj:108:5).
Index -1 out of bounds for length 0

Full report at:
/tmp/clojure-17707944337344531485.edn
make: *** [Makefile:16: watch-ui] Error 1

zipped /tmp/17707944337344531485

clojure-17707944337344531485.edn.zip

Got similar results with version 2.8.76.

@jpmonettas
Copy link
Owner

jpmonettas commented Nov 30, 2019

I wasn't able to reproduce that problem even after removing .shadow_cljs and node_modules.
I'm also on a linux environment, with shadow version: 2.8.76 node: v11.14.0
Check the latest commit where I added package-lock.json

On a side note, just deployed to clojars 0.1.7 which contains all the latest changes.

Thanks again for all the details, please let me know how it goes.

@sogaiu
Copy link
Author

sogaiu commented Nov 30, 2019

Thanks for adding package-lock.json.

I've tried with node 11.14.0 as well as 8 and 12 series without any luck unfortunately.

I've also tried Java 8 and 11 with no change.

Will ponder more.


The motivation to investigate came from trying to test out your change to address the width issue. Unfortunately, I encountered an issue, so I'll go report that separately now.

@jpmonettas jpmonettas added the bug Something isn't working label Dec 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants