-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
make watch-ui fails #2
Comments
On a side note, I don't see a package-lock.json (or a yarn lock file) as part of the repository. I think this may tend to lead to different environments making things less reproducible. What do you think of the idea of adding an appropriate lock file to the repository? |
After removing .shadow-cljs and node_modules, I added shadow-cljs 2.8.55 to the devDependencies of package.json, did npm install, and now I get:
zipped /tmp/17707944337344531485 clojure-17707944337344531485.edn.zip Got similar results with version 2.8.76. |
I wasn't able to reproduce that problem even after removing .shadow_cljs and node_modules. On a side note, just deployed to clojars 0.1.7 which contains all the latest changes. Thanks again for all the details, please let me know how it goes. |
Thanks for adding package-lock.json. I've tried with node 11.14.0 as well as 8 and 12 series without any luck unfortunately. I've also tried Java 8 and 11 with no change. Will ponder more. The motivation to investigate came from trying to test out your change to address the width issue. Unfortunately, I encountered an issue, so I'll go report that separately now. |
Was trying to test the latest code, and having encountered an issue there [1], tried to get things running from source.
On a fresh clone of the repository (7c191af), in the cloned directory, I get:
zipped /tmp/clojure-4309429650306985496.edn:
clojure-4309429650306985496.edn.zip
Am I doing something wrong or missing something?
FWIW, this is using a Linux distribution.
[1] May report that later after trying to resolve this issue.
The text was updated successfully, but these errors were encountered: