Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should be possible to use with a non-cryptographic hash #16

Open
frankier opened this issue Apr 4, 2018 · 4 comments
Open

Should be possible to use with a non-cryptographic hash #16

frankier opened this issue Apr 4, 2018 · 4 comments

Comments

@frankier
Copy link

frankier commented Apr 4, 2018

Really a non-cryptographic hash such as https://github.com/hajimes/mmh3 should be used. I guess this could be made the default for new filter objects and then a tag could be added to the format so that old files can be restored correctly but newly created files can use murmurhash. Thoughts about this?

@varunkumar
Copy link

Was there any progress on this?

@RoyZhang7
Copy link

I'm working on a small proof-of-concept research project using pybloom-live and planning to use murmur3 as one of hash funcs
I might submit a PR later.

@joseph-fox
Copy link
Owner

@varunkumar @RoyZhang7 please make a PR, I will review and merge it.

@varunkumar
Copy link

varunkumar commented Oct 6, 2022

@joseph-fox Please take a look at #38

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants