Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

isClearable CSS issue? #310

Open
cloke opened this issue Oct 23, 2024 · 3 comments
Open

isClearable CSS issue? #310

cloke opened this issue Oct 23, 2024 · 3 comments

Comments

@cloke
Copy link
Contributor

cloke commented Oct 23, 2024

With the addition of @isClearable to the Select component it appears to have a pointer-events-none on it which makes it not clickable. Curious if this is an oversight or intentional. If I remove the class the component works as expected. Happy to open a PR if the class should not be there.

@cloke cloke closed this as completed Oct 23, 2024
@cloke cloke reopened this Oct 23, 2024
@cloke
Copy link
Contributor Author

cloke commented Oct 23, 2024

Reopening as this seems to randomly work. The main thing is if I manually remove the pointer events class then everything works as selected. This has only been tested on multi select.

@josemarluedke
Copy link
Owner

We add a class to allow pointer events on the clear button. https://github.com/josemarluedke/frontile/blob/main/packages/theme/src/components/forms/forms.ts#L221

Are you by any chance overwriting styles?

Also, if you are only seeing this on multi-select, maybe you are clicking with the dropdown open? Which the click would only close the dropdown content, and then another click would be needed to on the clear button to capture that event.

image

@cloke
Copy link
Contributor Author

cloke commented Dec 3, 2024

We don't have any custom variants on this, but I need to return to it to get an isolated test case.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants