Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reset to Default HTML Body - Doesn't Work #39328

Closed
PMWilliams123 opened this issue Nov 29, 2022 · 10 comments
Closed

Reset to Default HTML Body - Doesn't Work #39328

PMWilliams123 opened this issue Nov 29, 2022 · 10 comments

Comments

@PMWilliams123
Copy link

Steps to reproduce the issue

In the System Dashboard --> Templates / Mail templates
Select "User Actions Log: Notification Mail" to edit
Click on the "Reset to Default HTML Body" button

Expected result

A reset HTML Body that works with correctly places {MESSAGES} tags:

_Latest User Actions
This is the latest action performed by a user on your website.
ActionDateExtensionName**{MESSAGES}**
{MESSAGE} {DATE} {EXTENSION} {USERNAME}
{/MESSAGES}
_

Actual result

_Latest User Actions
This is the latest action performed by a user on your website.
ActionDateExtensionName**{MESSAGES}{/MESSAGES}**
{MESSAGE} {DATE} {EXTENSION} {USERNAME}
_

System information (as much as possible)

Joomla 4.2.5
PHP 8.0.25
MySql 5.7

Additional comments

I think this is the correct way to customise emails and it does not , as Alison Meeks suggested mean that the Joomla Core files are being modified.

@Kostelano
Copy link
Contributor

Kostelano commented Nov 29, 2022

Works for me. No problem

Sorry, there really is a problem. At first I did not pay attention to the order of tags.

@PMWilliams123
Copy link
Author

Well it doesn't for me. On at least two of my Joomla installations:

A email format that works:
Existing.jpg

And after Clicking:
After Clicking Reset To Default HTMl Body.png
screen shot 2022-11-29 at 13 35 10

screen shot 2022-11-29 at 13 35 11


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39328.

@brianteeman
Copy link
Contributor

Just so we can be certain where the issue lies can you please test this using the tinymce editor and NOT the jce editor

@PMWilliams123
Copy link
Author

Certainly -- In global configuration I changed the editor to TinyMCE

System Dashboard --> Templates / Mail templates
Select "User Actions Log: Notification Mail" to edit
Click on the "Reset to Default HTML Body" button

Using Tiny MCE   Prsesseing Reset

@brianteeman
Copy link
Contributor

Thanks for confirming that

@PMWilliams123
Copy link
Author

Small Questions: Why are there only 4 Parameters one can use in editing "User Actions Log: Notification Mail - en-GB"? And why does this mail template require {MESSAGES} {/MESSGAES} tags when it appears than none of the other mail templates require those tags?

@PMWilliams123
Copy link
Author

Is anything happening to this?


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39328.

@Hackwar Hackwar added the bug label Feb 22, 2023
@Hackwar Hackwar added the PBF Pizza, Bugs and Fun label Aug 25, 2023
@brianteeman brianteeman removed the PBF Pizza, Bugs and Fun label Sep 1, 2023
@brianteeman
Copy link
Contributor

There are multiple things going wrong here

  1. the htmlbody string is sanitized by the html editor when it is loaded which is why {messages} is moved outside of the table
  2. {messages} is missing from the params field in the database which is why it doesnt appear in the list of tags to insert

PR on its way

@brianteeman
Copy link
Contributor

brianteeman commented Jan 9, 2025

Please test #44709

@alikon
Copy link
Contributor

alikon commented Jan 9, 2025

closing as we have a pr #44709

@alikon alikon closed this as completed Jan 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants