Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

This repository does not work with Joomla patchtester #293

Open
andrepereiradasilva opened this issue Mar 21, 2016 · 4 comments
Open

This repository does not work with Joomla patchtester #293

andrepereiradasilva opened this issue Mar 21, 2016 · 4 comments
Assignees

Comments

@andrepereiradasilva
Copy link
Contributor

This repository does not work with Joomla Patchtester.

Joomla (https://github.com/joomla/joomla-cms) and patchtester (https://github.com/joomla-extensions/patchtester) works.

patchtester-config

The PR are fetched but cannot be applied.

I think the structure of the folders needs to be like the patchtester repository. In other words, i think what is need is to change the administrator folder, from "component/admin" to "administrator/components/com_localise" and update the files that reference that folder.

@infograf768
Copy link
Contributor

@javigomez

As I have not decided this structure, can you give us your feedback?

As it is now, to update my test site I use with eclipse
"Build project" which uses a custom build.properties with the correct path to my test site.

And to create packs I use:
./phing -f /Users/mac/joomlatrunk/upstream_localise/build/build.xml

@mbabker
Copy link
Contributor

mbabker commented Mar 21, 2016

For any extension to work with patchtester its repo MUST be structured like the CMS. The patchtester component didn't do anything special for that. When it tries to apply a patch, the check literally equates to "can we patch JPATH_ROOT/<file_path_specified_in_diff>".

@infograf768
Copy link
Contributor

@mbabker
As you know, I did not structure this repo and I have absolutely no idea why it was not structured like the CMS. 😺

@mbabker
Copy link
Contributor

mbabker commented Mar 21, 2016

Personally I hate using that structure for extensions (how weblinks was structured before the test team started implementing their tools is closer to how I keep mine), but alas, that's the requirement to use the tool.

@infograf768 infograf768 self-assigned this Mar 21, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants