diff --git a/packages/pubsub/src/MessageHandlerIdempotent.ts b/packages/pubsub/src/MessageHandlerIdempotent.ts index 4acadcb..36b2d5e 100644 --- a/packages/pubsub/src/MessageHandlerIdempotent.ts +++ b/packages/pubsub/src/MessageHandlerIdempotent.ts @@ -6,7 +6,6 @@ import { ISubscriber } from './SubscriberFactory' type GetIdempotencyKeyFunction = (msg: T, info: IMessageInfo) => string | undefined export abstract class IdempotencyStorage { - public abstract exists(key: string): Promise public abstract save(key: string): Promise @@ -60,7 +59,7 @@ export abstract class MessageHandlerIdempotent { if (idempotencyKey) { const alreadyProcessed = await this.idempotencyStorage.exists(idempotencyKey) .catch(e => { - this.subscriber.logger?.info(`Error checking idempotency key: ${idempotencyKey}`, e) + this.subscriber.logger?.info(`Error checking idempotency key existence: ${idempotencyKey}`, e) return false }) if (alreadyProcessed) { diff --git a/packages/pubsub/src/redis-types/IRedisClient.ts b/packages/pubsub/src/redis-types/IRedisClient.ts index 8cedeb7..dc77b62 100644 --- a/packages/pubsub/src/redis-types/IRedisClient.ts +++ b/packages/pubsub/src/redis-types/IRedisClient.ts @@ -1,6 +1,6 @@ /** - * This file contains interfaces from https://github.com/join-com/caching , - * for a less duplicated code when implementing idempotent handler on services. + * This file contains interfaces from https://github.com/join-com/caching, to be able to have RedisIdempotencyStorage + * in the lib, to duplicate less code, when implementing idempotent handler in the services. */ export interface IFailure { @@ -22,13 +22,10 @@ export type RedisResult = ISuccess | IFailure export type OptionalRedisResult = ISuccess | ISuccess | IFailure export interface IRedisError { - error: Error } - export interface IRedisClient { - get(key: string): Promise> setex(key: string, secondsTtl: number, value: Buffer): Promise>