-
Notifications
You must be signed in to change notification settings - Fork 752
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
config option will reset the url #3344
Comments
Thank you! I'll investigate... |
hmm... this seems to be a somewhat "hairy" issue. I'm seeing a bunch of complicated tweaks from people who feel strongly about using Snap in their localized versions, and I'm afraid to touch them. I'm not even sure if this behavior might not have been introduced by someone on purpose... |
Thank you for your investigation! I'm not sure if it's a feature or a bug. I encountered the following complaints from users:
|
Late to this party, but we do need to re-work this code. I think these two requests are valid. The confusion/concern with languages is that when someone is given a URL that specifies a language, a user might want to change their language and not have to re-change it if they refresh the page. |
Michael, this is a special case where they configure the Snap index page with settings we've introduced for embedding the editor into online courses etc. (Bootstrap / Pyret, the UoC people etc.). In this particular case they could just switch the normal off-the-shelf Snap to their language and it would totally stay that way. I agree that we should rework this code, but - as mentioned above - I know that what makes it hairy has been touched a a lot of people with very strong interests in localization, and I'm afraid that we'd break existing real-life use cases when trying to adjust this for the special configuration settings. |
before adding config option
the url is
https://127.0.0.1:8000/snap.html#run:http://wwj718.github.io/post/img/snap-eclipse.xml
After adding config option:
The content after the hashtag in the URL will disappear:
https://127.0.0.1:8000/snap.html#
The text was updated successfully, but these errors were encountered: