Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add light/dark mode override #635

Open
Abhishek-465 opened this issue Sep 12, 2023 · 14 comments
Open

Add light/dark mode override #635

Abhishek-465 opened this issue Sep 12, 2023 · 14 comments
Assignees

Comments

@Abhishek-465
Copy link

I can add darkmode with the help of javascript.

@jmhobbs
Copy link
Owner

jmhobbs commented Sep 12, 2023

Hi @Abhishek-465!

We do have a dark mode CSS theme which uses @media (prefers-color-scheme: dark), but if you'd like to add a toggle or something to allow folks to change between light and dark mode, go for it!

@Abhishek-465
Copy link
Author

Ok then i am ready for it.

@AnshuWorld
Copy link

i want to contribute here please give me permission

@jmhobbs
Copy link
Owner

jmhobbs commented Oct 17, 2023

Hi @AnshuWorld you're more than welcome to have a try, PR #636 appears abandoned unfortunately.

@VBPMP
Copy link

VBPMP commented Oct 22, 2023

please, assign me this issue

@AnshuWorld
Copy link

AnshuWorld commented Oct 22, 2023

Hi @AnshuWorld you're more than welcome to have a try, PR #636 appears abandoned unfortunately.

Please share me the link also tell me what I have to do

@jmhobbs
Copy link
Owner

jmhobbs commented Oct 23, 2023

@AnshuWorld #636 has details on what needs to happen. Essentially, it should respect prefers-color-scheme but allow for an override by JavaScript.

@YashX777
Copy link

Hi @jmhobbs , Is this issue still open?
I would like to contribute to this. Please send the necessary links and details along with it.

Else Please let me know about any other isuue. Thanks

@jmhobbs
Copy link
Owner

jmhobbs commented Oct 1, 2024

Hi @YashX777, yep, this is still open. It should be more "add dark mode toggle", since we have a dark mode we just don't have a way to override the prefers-color-scheme

@jmhobbs jmhobbs changed the title Adding dark mode in the website. Add light/dark mode override Oct 1, 2024
@YashX777
Copy link

YashX777 commented Oct 3, 2024

Can you share all details pertaining to this issue?
And officially please assign me this .

@jmhobbs
Copy link
Owner

jmhobbs commented Oct 4, 2024

@YashX777 There's notes on #636 on roughly what I'd like. Somewhere on the page a toggle to switch light/dark theme, as well as some memory of that choice in browser storage. Something small preferably!

@jmhobbs jmhobbs assigned YashX777 and unassigned Abhishek-465 Oct 4, 2024
@YashX777
Copy link

I tried reading the README and deploying it, but it's showing a lot of errors. Is there any other file explaining it step by step?

@jmhobbs
Copy link
Owner

jmhobbs commented Oct 10, 2024

@YashX777 to do a local build you have to install a lot of things:

It would be difficult, but you could open a PR and make changes there, and Netlify will rebuild them for you. That would be a slow way to work though, it might be worth the effort to install the dependencies.

I will try to make the install instructions better as well and provide some more guidance in the README

@jmhobbs
Copy link
Owner

jmhobbs commented Oct 10, 2024

I added more details in #656, as well as some more flexible install checks for the JS based tools. 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants