Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Important documentation section has been deleted! #1137

Open
andrew-wja opened this issue Dec 11, 2024 Discussed in #789 · 3 comments
Open

Important documentation section has been deleted! #1137

andrew-wja opened this issue Dec 11, 2024 Discussed in #789 · 3 comments

Comments

@andrew-wja
Copy link

The docs section linked to in this comment has been deleted, and there are still stale references to it in the RST docs source files. This is super important -- I don't want ytdl-sub to redownload terabytes of 4K content from Youtube! Surely this should be on by default? And the docs should not have been deleted? I eventually found out how to set this crucial setting by reading the code 😢

https://github.com/jmbannon/ytdl-sub/blob/master/src/ytdl_sub/config/preset_options.py#L113

It appears there is also a bug because I am using the ytdl-sub-gui:latest image and this option is not on by default, but according to the YAML parsing code it should default to True if not set.

Discussed in #789

Originally posted by bencdll October 31, 2023
It seems that every time I run ytdl-sub it redownloads everything. How can I make it download only new videos?

@andrew-wja
Copy link
Author

andrew-wja commented Dec 11, 2024

Here's some reduced example config.yaml and subscriptions.yaml files to test with:

configuration:
  working_directory: ".ytdl-sub-working-directory"

presets:
  TV Show:
    preset:
      - "Jellyfin TV Show by Date"
      - "Only Recent"
__preset__:
  overrides:
    tv_show_directory: "/data"
    only_recent_date_range: "15years"
    only_recent_max_files: 1

Jellyfin TV Show by Date | Only Recent:

  = Reality:
    "Fireplace 4K": "https://www.youtube.com/playlist?list=PLCBpXMNymy2rZ_PFn8z63jxpxp7aOlBmI"
    "Virtual Fireplace": "https://youtube.com/playlist?list=PLEO2ywhsmOLni56qGYyLWW34yoCQ5l3Oy&feature=shared"

@andrew-wja
Copy link
Author

ytdl-sub deleting and redownloading 10-hour 2160p videos seems like a worst possible outcome here 🫤

@jmbannon
Copy link
Owner

The TV show presets enable the archive by default. only_recent_max_files: 1 is of concern, this means you only want to keep a single video at a time for any subscription

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants