Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make possible to ignore multiple items with single action in Media Relinker #1175

Open
thennicke opened this issue Dec 29, 2024 · 4 comments

Comments

@thennicke
Copy link

thennicke commented Dec 29, 2024

Flowblade version 2.18 running on Fedora (Wayland).

There does not seem to be a way to mass-remove media from bins. Attempting to delete a bin gives me a "cannot delete bin without first removing media", but if I select all media in it and press delete, nothing happens. If I attempt to right click once all are selected, the selection cancels and the menu only applies to the single media item.

I have bins with 481 and 602 images in them respectively that I want to delete and I cannot find a way to achieve this.

A related complaint is that the media relinker tool does not allow a bulk ignore (or generate placeholder media) option. This becomes an issue when I've gone through in my OS' file manager and manually deleted a bunch of bad images from a folder, despite the whole folder already having been loaded into a Flowblade bin.

@jliljebl jliljebl added the bug label Dec 30, 2024
@jliljebl
Copy link
Owner

There does not seem to be a way to mass-remove media from bins. Attempting to delete a bin gives me a "cannot delete bin without first removing media", but if I select all media in it and press delete, nothing happens. If I attempt to right click once all are selected, the selection cancels and the menu only applies to the single media item.

Ahh, ok. You can actually delete all media in a Bin with single action by doing:

  1. Click on the first Media Item in Bin
  2. Shift + Left mouse click on the last item in bin
  3. Press Delete Key

But we clearly need some improvement here because you were not able to find this workflow.

The reason it does not delete all Media Items after selecting Select All from hamburger menu is that media items do not have the keyboard focus after menu selection, and we use that to determine if we are deleting e.g. Timeline Clips or Media Items.

I believe I can fix this by programmatically setting keyboard focus after Select All menu selection.

A related complaint is that the media relinker tool does not allow a bulk ignore (or generate placeholder media) option. This becomes an issue when I've gone through in my OS' file manager and manually deleted a bunch of bad images from a folder, despite the whole folder already having been loaded into a Flowblade bin.

I'll test and analyze this to see how we improve here.

I'll label as bug, because we are currently in violation of a strong and correct user expectation to be able to do delete after Select All.

@thennicke
Copy link
Author

Thanks for this -- appreciate the context, and I was able to get my project back on track with your help.

The only thing I'd add is that as a user I expect the bins to use the same norms and standards as a file manager -- for example if I select all and right click, that menu should apply to all selected items and not just the one I right click on. The design as it currently stands is counterintuitive to me.

@jliljebl
Copy link
Owner

for example if I select all and right click, that menu should apply to all selected items and not just the one I right click on. The design as it currently stands is counterintuitive to me.

I'll see what can be done here.

@jliljebl
Copy link
Owner

jliljebl commented Jan 6, 2025

For the delete multiple media items issue I did:

  1. Added popover to be displayed when multiple items are selected, this has actions that can be applied to muitiple items such as Delete, Render Proxies and a few more.

  2. Made Media Items grab keyboard focus after Select All from hamburger menu so they can now be deleted with Delete key after that selection.

  3. Added Delete item in hamburger menu, so that selected items can be deleted from there too.

Altogether I think we have this now covered, I'll change the issue name and label to reflect we are still trying to improve on

the media relinker tool does not allow a bulk ignore (or generate placeholder media) option. This becomes an issue when I've gone through in my OS' file manager and manually deleted a bunch of bad images from

thing which is more of a feature request.

@jliljebl jliljebl changed the title No way to mass-remove media from bins Make possible to ignore multiple items with single action in Media Relinker Jan 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants