From 49b591cd09bcbed53efdc756454c11e27a70a3b7 Mon Sep 17 00:00:00 2001 From: Zack Zlotnik Date: Mon, 22 Aug 2022 15:06:16 -0400 Subject: [PATCH] fixes config decompression lint issue This was caught by the gosec linter in the Hypershift project; gosec G110. --- pkg/controller/common/helpers.go | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/pkg/controller/common/helpers.go b/pkg/controller/common/helpers.go index 6954d1e922..c2b1428b27 100644 --- a/pkg/controller/common/helpers.go +++ b/pkg/controller/common/helpers.go @@ -585,8 +585,6 @@ func decompressPayload(r io.Reader) ([]byte, error) { return nil, errConfigNotGzipped } - out := bytes.NewBuffer([]byte{}) - gz, err := gzip.NewReader(in) if err != nil { return nil, fmt.Errorf("initialize gzip reader failed: %w", err) @@ -594,12 +592,12 @@ func decompressPayload(r io.Reader) ([]byte, error) { defer gz.Close() - // Decompress our payload. - if _, err := io.Copy(out, gz); err != nil { + data, err := ioutil.ReadAll(gz) + if err != nil { return nil, fmt.Errorf("decompression failed: %w", err) } - return out.Bytes(), nil + return data, nil } // Function to remove duplicated files/units/users from a V2 MC, since the translator