Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Behaviour of UnshortenIt() object and the unshorten() call in the documentation is wrong #26

Open
fake-name opened this issue May 11, 2018 · 0 comments · May be fixed by #27
Open

Behaviour of UnshortenIt() object and the unshorten() call in the documentation is wrong #26

fake-name opened this issue May 11, 2018 · 0 comments · May be fixed by #27

Comments

@fake-name
Copy link
Contributor

The documentation currently states:

By default the library will not make any HTTP request if the url provided does not match any of the modules url patterns. To override this you may pass force=True to the unshorten method.

However, looking at https://github.com/jkehler/unshortenit/blob/master/unshortenit/unshortenit.py#L70, it appears every URI passed to the library will results in a HTTP request, presumably to resolve 30x redirects.

Additionally, the force argument seems to be ignored.

I assume this was for the ability to make 30x resolution optional (which I PR-ed a while ago)?
fake-name added a commit to fake-name/unshortenit that referenced this issue May 11, 2018
@fake-name
Fix jkehler#26, add more logging.
547d466
@fake-name fake-name linked a pull request May 11, 2018 that will close this issue
Open
@fake-name fake-name changed the title Documentation is wrong. Behaviour of UnshortenIt() object and the unshorten() call in the documentation is wrong May 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
1 participant
@fake-name