Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Benchmark with fast float #6

Open
sirinath opened this issue Dec 12, 2020 · 4 comments
Open

Benchmark with fast float #6

sirinath opened this issue Dec 12, 2020 · 4 comments

Comments

@sirinath
Copy link

How does the performance compare with;

@jk-jeon
Copy link
Owner

jk-jeon commented Dec 12, 2020

I remember I did a benchmark against fast_double_parser by myself, and the result was that fast_double_parser is significantly faster than my implementation on reasonable (up to, say, 17 digits) length inputs. Of course, on longer inputs fp is much faster simply because fast_double_parser just gives up parsing such inputs and falls back to standard library implementations. It is my plan to dig into Dr. Lemire's implementation and reimplement it myself (with some modification) to replace my original implementation. (I will be happier if someone else can do that for me instead:) )

However, for me it is rather a bad idea to just reuse his implementation, because that means unnecessary duplication of otherwise mostly same cache tables.

@sirinath
Copy link
Author

How can the cache tables be adopted to be shared?

@jk-jeon
Copy link
Owner

jk-jeon commented Dec 14, 2020

Because I expect most of the entries would be the same?
Even if it's not the case, I think there might be ways to workaround the issue.

@sirinath
Copy link
Author

Looking forward to this implementation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants