Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Java module-info.java #64

Open
nhojpatrick opened this issue Mar 3, 2020 · 1 comment
Open

Java module-info.java #64

nhojpatrick opened this issue Mar 3, 2020 · 1 comment

Comments

@nhojpatrick
Copy link
Contributor

I'm happy to do the work but after some discussion at apache commons, I would propose a major version bump for adding module-info into typetools.

  1. Any downstream projects using class scanners potentially won't understand module-info so will break projects.
  2. I propose using Multi Release Jar, so;
    2.1) Make min java version requirement 1.8
    2.2) Update build to have src/main/java11/module-info.java (only that single java11 file)
    2.3) Compile module-info.java into META-INF/versions/11/module-info
  3. I don't propose supporting any other versions apart from 1.8 and 11, which are both LTS, afterwards others could be added if useful.
  4. I'm happy to do the alterations and submit a PR for v1.x.x

Thoughts?

@jhalterman
Copy link
Owner

Why do you think a multi-release jar would be necessary, and similar for the 1.8 requirement?

Repository owner deleted a comment from duomianti1987 Apr 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants