You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
If typetools marked sun.reflect as an optional package in its OSGi manifest, then in case when its functionality required, one would need to follow the OSGi instructions (as per README) the same way as before.
However, in cases when typetools is a transient dependency (cqengine, for example, depends on it for a small part of its functionality), it is useful when this functionality is not going to be used and therefore there is no need to add sun.reflect to extras.
What do you think?
The text was updated successfully, but these errors were encountered:
@yrashk I saw that discussion... I'm not an OSGi user myself, but I'd be fine with marking sun.reflect as optional (or taking a pull request along those lines) so long as it could still be manually imported and verified that things work as expected.
I assume that cqengine just doesn't need lambda type arg resolution (which the sun.reflect code is used for) ?
Hi Jonathan, currently CQEngine has its own code for detecting generic types in non-lambda objects, and it's only using typetools for the lambda support actually.
But going forward I plan to remove the remaining code in CQEngine and to use typetools for the non-lambda stuff too. Thanks for TypeTools it's really a great library btw!
Hi Jonathan,
This issue is in reference to npgall/cqengine#94
If typetools marked
sun.reflect
as an optional package in its OSGi manifest, then in case when its functionality required, one would need to follow the OSGi instructions (as per README) the same way as before.However, in cases when typetools is a transient dependency (cqengine, for example, depends on it for a small part of its functionality), it is useful when this functionality is not going to be used and therefore there is no need to add
sun.reflect
to extras.What do you think?
The text was updated successfully, but these errors were encountered: