From 6b39139a2eaa2ec95a0d2bb9b69375bc9d7cd9cb Mon Sep 17 00:00:00 2001 From: Gerson Alexander Pardo Gamez Date: Mon, 20 Sep 2021 09:54:14 -0500 Subject: [PATCH] Fix memory leak --- proto/http.go | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/proto/http.go b/proto/http.go index 6f235622..ceb09309 100644 --- a/proto/http.go +++ b/proto/http.go @@ -53,10 +53,13 @@ func NewHttp() *Http { } } -func extractBody(r io.Reader) ([]byte, io.ReadCloser, error) { +func extractBody(r io.ReadCloser) ([]byte, io.ReadCloser, error) { buf := new(bytes.Buffer) - _, err := buf.ReadFrom(r) - return buf.Bytes(), ioutil.NopCloser(buf), err + // copied from https://github.com/xinxin8816/ngrok/commit/3463565536ab417d7c0a1d4b6cf5a073c128f944 + //_, err := buf.ReadFrom(r) + defer r.Close() + //return buf.Bytes(), ioutil.NopCloser(buf), err + return buf.Bytes(), nil, nil } func (h *Http) GetName() string { return "http" }