Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clear cases of non-recombinants #346

Closed
szhan opened this issue Feb 25, 2025 · 12 comments
Closed

Clear cases of non-recombinants #346

szhan opened this issue Feb 25, 2025 · 12 comments

Comments

@szhan
Copy link
Collaborator

szhan commented Feb 25, 2025

Discussion started with XN in #285 and then with these other Pango X.
XAU
XBQ
XBK (XBK.1)
XBE

Quoting Yan here in #285:
"No clear recombination, and no reversions etc on the nearby branches. Unless there is a deletion we are missing, I suppose."

@szhan
Copy link
Collaborator Author

szhan commented Feb 25, 2025

XAU

Image from Yan copied from #285.
Image

@szhan
Copy link
Collaborator Author

szhan commented Feb 25, 2025

XBQ and XBK

Image from Yan copied from #285.
Image

@szhan
Copy link
Collaborator Author

szhan commented Feb 25, 2025

XBE

Image from Yan copied from #285.

Image

@jeromekelleher
Copy link
Owner

I think XN should be here also?

@szhan
Copy link
Collaborator Author

szhan commented Feb 25, 2025

I think XN should be here also?

Yes, but it has its own issue.

@szhan
Copy link
Collaborator Author

szhan commented Feb 25, 2025

XN

Image from Yan copied from #285.

Image

@jeromekelleher
Copy link
Owner

I see - I got confused when this was titled "Clear cases of non recombinant" and it was omitted though.

@jeromekelleher
Copy link
Owner

I was hoping that we could gather evidence for each of these cases in separate threads (optionally with some linking issues) so that we could easily find them and add to them. This is basically the same as #285 now.

@szhan
Copy link
Collaborator Author

szhan commented Feb 25, 2025

I thought we separate the clear cases from the less clear cases, for which we have a separate issue each?

@szhan
Copy link
Collaborator Author

szhan commented Feb 25, 2025

We could just close this and retitle #285?

@jeromekelleher
Copy link
Owner

We need to list out the evidence somewhere for why we think something is not a recombinant, all we have at the moment is a few pictures which are hard to collate. I want to have, for each thing which disagrees with pango ground truth:

  • A picture from sc2ts summarising the topology
  • Information about the original matches from the match file (along with follow-up matches with different params, if marginal)
  • What recombinhunt and other methods think
  • Links to any other relevant information, like Pango designation issue and analyses that Katherine might have done.

So we're using these issue to collate information in a way that's findable and extendable. We can then make qualitative judgements about things that are definitely one other or another later on.

I think #337, #338, #338 and #339 are are a great start on this.

@szhan
Copy link
Collaborator Author

szhan commented Feb 25, 2025

Okay, closing this and starting issues for each non-recombinant.

@szhan szhan closed this as completed Feb 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants