Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Breakpoints groups and multipliers not supported. #5

Open
iberdinsky-skilld opened this issue Nov 13, 2017 · 1 comment
Open

Breakpoints groups and multipliers not supported. #5

iberdinsky-skilld opened this issue Nov 13, 2017 · 1 comment

Comments

@iberdinsky-skilld
Copy link

iberdinsky-skilld commented Nov 13, 2017

According to: https://www.drupal.org/docs/8/theming-drupal-8/working-with-breakpoints-in-drupal-8 it is possible to join queries in groups. And use multipliers. Currently if use example from
http://cgit.drupalcode.org/drupal/tree/core/modules/breakpoint/tests/themes/breakpoint_theme_test/breakpoint_theme_test.breakpoints.yml
breakpoint file:

breakpoint_theme_test.mobile:
  label: mobile
  mediaQuery: '(min-width: 0px)'
  weight: 0
  multipliers:
    - 1x
breakpoint_theme_test.narrow:
  label: narrow
  mediaQuery: '(min-width: 560px)'
  weight: 1
  multipliers:
    - 1x
# Out of order breakpoint to test sorting.
breakpoint_theme_test.tv:
  label: tv
  mediaQuery: 'only screen and (min-width: 1220px)'
  weight: 3
  multipliers:
    - 1x
breakpoint_theme_test.wide:
  label: wide
  mediaQuery: '(min-width: 851px)'
  weight: 2
  multipliers:
    - 1x
breakpoint_theme_test.group2.narrow:
  label: narrow
  mediaQuery: '(min-width: 560px)'
  weight: 0
  multipliers:
    - 1x
    - 2x
  group: breakpoint_theme_test.group2
breakpoint_theme_test.group2.wide:
  label: wide
  mediaQuery: '(min-width: 851px)'
  weight: 1
  multipliers:
    - 1x
    - 2x
  group: breakpoint_theme_test.group2

Result will be:

$mobile: '(min-width: 0px)';
$narrow: '(min-width: 560px)';
$tv: 'only screen and (min-width: 1220px)';
$wide: '(min-width: 851px)';
$narrow: '(min-width: 560px)';
$wide: '(min-width: 851px)';

$drupal-breakpoints: (
  mobile: '(min-width: 0px)',
  narrow: '(min-width: 560px)',
  tv: 'only screen and (min-width: 1220px)',
  wide: '(min-width: 851px)',
  narrow: '(min-width: 560px)',
  wide: '(min-width: 851px)',
);

No multipliers and no groups.

@iberdinsky-skilld
Copy link
Author

#6

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant