Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disallow @ in usernames #380

Open
1 of 2 tasks
jedmund opened this issue Sep 4, 2023 · 1 comment
Open
1 of 2 tasks

Disallow @ in usernames #380

jedmund opened this issue Sep 4, 2023 · 1 comment
Labels
priority: medium Somewhat important tasks

Comments

@jedmund
Copy link
Owner

jedmund commented Sep 4, 2023 •
edited
Loading

Thanks luis14402 (Also this user can't access their profile because of the @)

  • Are there other potentially bad special characters we shouldn't allow in usernames?
  • Determine whether force-changing a username will break something for the user (in cookies, for example)
@jedmund jedmund added the priority: medium Somewhat important tasks label Sep 4, 2023
@jedmund
Copy link
Owner Author

jedmund commented Sep 4, 2023

Force-changing a username doesn't seem to permanently break anything. The profile link is the right menu rendered as the username when the user logs in, so we should change that to a /me endpoint that gets the profile of the currently logged in user.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
priority: medium Somewhat important tasks
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jedmund