From 871e411616a5689a2aa86051e05f0c2c77daf4fc Mon Sep 17 00:00:00 2001 From: John DeRegnaucourt Date: Mon, 11 Dec 2023 01:08:58 -0500 Subject: [PATCH] fixed insidious little bug. "" compared with == instead of .equals(). Was working because "" was usually within the LRUCache, unless it's size was set small enough. --- src/test/java/com/cedarsoftware/util/TestCompactMap.java | 2 +- src/test/java/com/cedarsoftware/util/TestConverter.java | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/test/java/com/cedarsoftware/util/TestCompactMap.java b/src/test/java/com/cedarsoftware/util/TestCompactMap.java index bc9c76595..fdcd4b32d 100644 --- a/src/test/java/com/cedarsoftware/util/TestCompactMap.java +++ b/src/test/java/com/cedarsoftware/util/TestCompactMap.java @@ -75,7 +75,7 @@ protected Map getNewMap() assert map.size() == 2; assert !map.isEmpty(); - assert map.remove("alpha") == "beta"; + assert map.remove("alpha").equals("beta"); assert map.size() == 1; assert !map.isEmpty(); diff --git a/src/test/java/com/cedarsoftware/util/TestConverter.java b/src/test/java/com/cedarsoftware/util/TestConverter.java index 3442c5648..842db09c7 100644 --- a/src/test/java/com/cedarsoftware/util/TestConverter.java +++ b/src/test/java/com/cedarsoftware/util/TestConverter.java @@ -1480,7 +1480,7 @@ public void testNullInstance() assert false == convert2AtomicBoolean(null).get(); assert 0 == convert2AtomicInteger(null).get(); assert 0L == convert2AtomicLong(null).get(); - assert "" == convert2String(null); + assert "".equals(convert2String(null)); } @Test