From f60d12cabcce7531ae6e648bf141062567188acb Mon Sep 17 00:00:00 2001 From: Jacob van Mourik Date: Sat, 4 Feb 2017 15:58:00 +0100 Subject: [PATCH] Fixed version check --- src/main/java/com/jvms/i18neditor/editor/Editor.java | 6 ++---- src/main/java/com/jvms/i18neditor/editor/EditorMenuBar.java | 2 +- 2 files changed, 3 insertions(+), 5 deletions(-) diff --git a/src/main/java/com/jvms/i18neditor/editor/Editor.java b/src/main/java/com/jvms/i18neditor/editor/Editor.java index 9d41a49..1f6a355 100644 --- a/src/main/java/com/jvms/i18neditor/editor/Editor.java +++ b/src/main/java/com/jvms/i18neditor/editor/Editor.java @@ -472,12 +472,10 @@ public void showVersionDialog(boolean newVersionOnly) { } catch (InterruptedException | ExecutionException | TimeoutException e) { data = null; } - if (data != null && !VERSION.equals(data.getTagName())) { + if (data != null && VERSION.compareToIgnoreCase(data.getTagName()) < 0) { content = MessageBundle.get("dialogs.version.new") + " " + "" + data.getTagName() + "
" + - "" + - MessageBundle.get("dialogs.version.link") + - ""; + "" + MessageBundle.get("dialogs.version.link") + ""; } else if (!newVersionOnly) { content = MessageBundle.get("dialogs.version.uptodate"); } else { diff --git a/src/main/java/com/jvms/i18neditor/editor/EditorMenuBar.java b/src/main/java/com/jvms/i18neditor/editor/EditorMenuBar.java index e788a57..3045d37 100644 --- a/src/main/java/com/jvms/i18neditor/editor/EditorMenuBar.java +++ b/src/main/java/com/jvms/i18neditor/editor/EditorMenuBar.java @@ -219,7 +219,7 @@ private void setupUI() { helpMenu.setMnemonic(MessageBundle.getMnemonic("menu.help.vk")); JMenuItem versionMenuItem = new JMenuItem(MessageBundle.get("menu.help.version.title")); - versionMenuItem.addActionListener(e -> editor.showVersionDialog(true)); + versionMenuItem.addActionListener(e -> editor.showVersionDialog(false)); JMenuItem aboutMenuItem = new JMenuItem(MessageBundle.get("menu.help.about.title", Editor.TITLE)); aboutMenuItem.addActionListener(e -> editor.showAboutDialog());