Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

logging in ajc is not thread safe -> parameter log is necessary - please add it #15

Closed
deltatree opened this issue Nov 11, 2014 · 12 comments

Comments

@deltatree
Copy link

at java.util.Stack.peek(Stack.java:85)
at java.util.Stack.pop(Stack.java:67)
at org.aspectj.bridge.context.CompilationAndWeavingContext.leavingPhase(CompilationAndWeavingContext.java:163)
at org.aspectj.weaver.bcel.BcelWeaver.weaveAndNotify(BcelWeaver.java:1417)
at org.aspectj.weaver.bcel.BcelWeaver.weave(BcelWeaver.java:1184)
at org.aspectj.ajdt.internal.compiler.AjPipeliningCompilerAdapter.weaveQueuedEntries(AjPipeliningCompilerAdapter.java:514)
at org.aspectj.ajdt.internal.compiler.AjPipeliningCompilerAdapter.afterCompiling(AjPipeliningCompilerAdapter.java:375)
at org.aspectj.ajdt.internal.compiler.CompilerAdapter.ajc$afterReturning$org_aspectj_ajdt_internal_compiler_CompilerAdapter$2$f9cc9ca0(CompilerAdapter.aj:78)
at org.aspectj.org.eclipse.jdt.internal.compiler.Compiler.compile(Compiler.java:421)
at org.aspectj.ajdt.internal.core.builder.AjBuildManager.performCompilation(AjBuildManager.java:1036)
at org.aspectj.ajdt.internal.core.builder.AjBuildManager.performBuild(AjBuildManager.java:272)
at org.aspectj.ajdt.internal.core.builder.AjBuildManager.batchBuild(AjBuildManager.java:185)
at org.aspectj.ajdt.ajc.AjdtCommand.doCommand(AjdtCommand.java:112)
at org.aspectj.ajdt.ajc.AjdtCommand.runCommand(AjdtCommand.java:60)
at org.aspectj.tools.ajc.Main.run(Main.java:371)
at com.jcabi.maven.plugin.AjcMojo.execute_aroundBody2(AjcMojo.java:194)
at com.jcabi.maven.plugin.AjcMojo$AjcClosure3.run(AjcMojo.java:1)
at org.aspectj.runtime.reflect.JoinPointImpl.proceed(JoinPointImpl.java:149)
at com.jcabi.aspects.aj.MethodLogger.wrap(MethodLogger.java:208)
at com.jcabi.aspects.aj.MethodLogger.ajc$inlineAccessMethod$com_jcabi_aspects_aj_MethodLogger$com_jcabi_aspects_aj_MethodLogger$wrap(MethodLogger.java:1)
at com.jcabi.aspects.aj.MethodLogger.wrapMethod(MethodLogger.java:164)
at com.jcabi.maven.plugin.AjcMojo.execute_aroundBody4(AjcMojo.java:185)
at com.jcabi.maven.plugin.AjcMojo$AjcClosure5.run(AjcMojo.java:1)
at org.aspectj.runtime.reflect.JoinPointImpl.proceed(JoinPointImpl.java:149)
at com.jcabi.aspects.aj.MethodLogger.wrapClass(MethodLogger.java:134)
at com.jcabi.maven.plugin.AjcMojo.execute(AjcMojo.java:185)
at org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo(DefaultBuildPluginManager.java:132)
at org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:208)
at org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:153)
at org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:145)
at org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject(LifecycleModuleBuilder.java:116)
at org.apache.maven.lifecycle.internal.builder.multithreaded.MultiThreadedBuilder$1.call(MultiThreadedBuilder.java:188)
at org.apache.maven.lifecycle.internal.builder.multithreaded.MultiThreadedBuilder$1.call(MultiThreadedBuilder.java:184)
at java.util.concurrent.FutureTask$Sync.innerRun(FutureTask.java:303)
at java.util.concurrent.FutureTask.run(FutureTask.java:138)
at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:441)
at java.util.concurrent.FutureTask$Sync.innerRun(FutureTask.java:303)
at java.util.concurrent.FutureTask.run(FutureTask.java:138)
at java.util.concurrent.ThreadPoolExecutor$Worker.runTask(ThreadPoolExecutor.java:886)
at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:908)
at java.lang.Thread.run(Thread.java:662)
@yegor256
Copy link
Member

@deltatree I didn't understand how to fix the issue (and how to reproduce it :) please give a bit more details

@deltatree
Copy link
Author

@yegor256 -log is a further parameter of ajc like source or target - See: https://www.eclipse.org/aspectj/doc/next/devguide/ajc-ref.html
To reproduce it you have to build a maven multi module project multithreaded: mvn -T 8C clean install

Thanks a lot!!!

Alex

@yegor256
Copy link
Member

@deltatree just add -log and that's it? it will help?

@deltatree
Copy link
Author

Yes, it is really so easy :-)

yegor256 pushed a commit that referenced this issue Nov 11, 2014
@yegor256
Copy link
Member

@rultor release, tag is 0.10.1

@rultor
Copy link
Contributor

rultor commented Nov 11, 2014

@rultor release, tag is 0.10.1

@yegor256 OK, I will release it now. Please check the progress here

@rultor
Copy link
Contributor

rultor commented Nov 11, 2014

@rultor release, tag is 0.10.1

@yegor256 Done! FYI, the full log is here (took me 13min)

@yegor256
Copy link
Member

@deltatree version 0.10.1 is in Maven Central. if works for you, please close the ticket

@deltatree
Copy link
Author

hmmm: not only -log, also a value is necessarry

@deltatree deltatree reopened this Nov 11, 2014
@yegor256
Copy link
Member

open a new ticket please. this one is done and released.

@deltatree
Copy link
Author

hmmm: not only -log, also a value is necessary like for -source or -target

@deltatree
Copy link
Author

okay - I'll open a new new one -> "-log needs also a value like -source or -target"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants