Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

child modules mention com.ocpsoft:prettyfaces, but it's not used. #135

Open
mdanter opened this issue May 24, 2016 · 3 comments
Open

child modules mention com.ocpsoft:prettyfaces, but it's not used. #135

mdanter opened this issue May 24, 2016 · 3 comments

Comments

@mdanter
Copy link

mdanter commented May 24, 2016

There is a rather old an unused (there is no pretty-config.xml, or annotations present) dependency bundled with this project. Please consider removing.

$ grep -inr ocpsoft *
carmart/pom.xml:29:        <com.ocpsoft.prettyfaces.version>3.3.2</com.ocpsoft.prettyfaces.version>
carmart/pom.xml:100:                <groupId>com.ocpsoft</groupId>
carmart/pom.xml:102:                <version>${com.ocpsoft.prettyfaces.version}</version>
carmart/pom.xml:170:            <groupId>com.ocpsoft</groupId>
carmart-tx/pom.xml:28:        <com.ocpsoft.prettyfaces.version>3.3.2</com.ocpsoft.prettyfaces.version>
carmart-tx/pom.xml:141:                <groupId>com.ocpsoft</groupId>
carmart-tx/pom.xml:143:                <version>${com.ocpsoft.prettyfaces.version}</version>
carmart-tx/pom.xml:224:            <groupId>com.ocpsoft</groupId>
@slaskawi
Copy link
Contributor

Implementing changes in branch 7.0.x (JDG 7). This is the latest version that should be used.

@slaskawi
Copy link
Contributor

Unfortunately it looks like this component can not be removed.

carmart and carmart-tx have also profile for deploying on Tomcat (which is not a JEE server and does not provide JSF implementation). The original quickstart author (@mgencur please correct me if I'm wrong) probably wanted to achieve the same behavior in all containers and that's why this library is always added to the WAR.

@mgencur
Copy link
Contributor

mgencur commented Aug 26, 2016

Right. It needs to be there. It could be moved to the Tomcat profile at best.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants