Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Position property is not working #63

Open
dstep2007 opened this issue Apr 13, 2016 · 0 comments
Open

Position property is not working #63

dstep2007 opened this issue Apr 13, 2016 · 0 comments

Comments

@dstep2007
Copy link

You have property to change the position of the popup but it is not hooked up from what I can tell. I made the following change to line 113 in the "add" function to make it work properly:

(old)
position = $.gritter.options.position,

(new working)
position = params.position || $.gritter.options.position,

please have a look at this and let me know if I am mis-using your module. maybe there is a different way to set position that I didn't find.

if you want, i can submit a PR with this change. thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant