Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't wrap runtime exceptions with another RuntimeException #29

Open
longtimeago opened this issue Sep 24, 2018 · 1 comment
Open

Don't wrap runtime exceptions with another RuntimeException #29

longtimeago opened this issue Sep 24, 2018 · 1 comment

Comments

@longtimeago
Copy link

longtimeago commented Sep 24, 2018

We've found the lib very useful, thanks for it!
Unfortunately, there is one thing which prevents it to be used with org.springframework.web.bind.annotation.ControllerAdvice exception handling contrroller from spring-mvc
Every time the lib catchers exception it wraps the exception with RuntimeException.

Would it be better to wrap only checked exceptions and propagate unckecked as they are?

@longtimeago
Copy link
Author

/cc @jasongoodwin

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant