Generating wrong css for :after :before pseudo selectors

[chandu0101]

 val reactTreeView = style(
       &.before.after(
        content := "g"
       )
    )

producing

.ReactTreeView_DefaultStyle-0001::after::before {
  content: g;
}

adding :: instead of :

[cretz]

I am also seeing this. According to MDN this is CSS 3 and should work in modern browsers.

[chandu0101]

yeah its working fine in new browsers ,but poor IE8 doesn't support it :p . tbh i don't care about IE8 as i only support flexbox browsers:)

[japgolly]

So according to the CSS3 spec we're doing the right thing. I think this is fine. IE8 will be forgotten long enough 😀

If this becomes a big deal, reopen and we can discuss what to do. Else I'm happy to leave this as is.

[cretz]

@japgolly, maybe there should be a way to add custom pseudo selectors instead of sealing the class since it's not used for exhaustivity checks (or is it)? Granted I know in this case you can just use strings to get what you need, but I have a similar problem where I need a custom media query selector and I cannot figure out how to do without forking (mentioned in gitter, but I might open an issue shortly).

[japgolly]

@cretz Oh! Pseudo selectors are sealed out of habit. I originally started with empty case classes and Pseudo => Xs then, specifically so users could create their own, I moved their attributes into the class itself. Guess I forgot to unseal it :) I'll do that now.

[japgolly]

No wait, I'm talking rubbish, you can create your own using Pseudo.Custom() and compose using &. Can you give that a try?

[japgolly]

@cretz Moving to #50 as we've moved off the original issue topic.