-
Notifications
You must be signed in to change notification settings - Fork 156
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GHCR docker container? #17
Comments
Hello @aaomidi My motherlanguage is German, sorry if my english isnt good enough to undertand this slim-describen issue. |
Dockerhub has rate limiting in place: https://docs.docker.com/docker-hub/download-rate-limit/ I dont believe its something you, as the person creating the image should worry about. Host wherever you feel appropriate |
Oh yeah I was asking for GHCR in addition to docker hub. I can even make the PR for this, it's pretty simple since you just add another tag to the image and push it to GHCR. |
Sure do a PR and i will look into that |
Hey @aaomidi that PR looked good to me so i merged it, the documentation didnt really mention to setup permissions before hand so i had to figure out that the hard way. Ive dont that and now its on GHCR also. But its weird,it looks like its 2 architectures somehow?! Would this be compatible with #23 also? |
… to satisfy #23 with short git-sha tag
I made it now compatible with #23 @aaomidi But my question remains un-answered, why are there no 2 architectures with is one of them unknown??!? |
Thank you so much for figuring out the few things there. I believe what's happening is provenance attestations: https://docs.docker.com/build/attestations/slsa-provenance/ I remember running into this problem before. Seems like it is a known issue with GHCR: https://github.com/orgs/community/discussions/45969 I remember just working around it by switching to |
No problem, happy to help
ehh yeah .... 😕 |
Oh, some potentially good news: docker/build-push-action#900 |
Very nice! |
Can this issue be closed? If you like this project, please give this repo and the docker-hub-repo a Star. |
Have you read the Important information text above
Current behavior
Container is only shared on docker hub.
Desired behavior
GitHub Container Registry is also a place to get the containers from
Links to screenshots
No response
To Reproduce
N/A
Software setup
N/A
Hardware setup
N/A
Additional context
GHCR has a lot more permissive rate limiting.
The text was updated successfully, but these errors were encountered: