Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor signaturetest module tests #1483

Open
starksm64 opened this issue Aug 21, 2024 · 3 comments
Open

Refactor signaturetest module tests #1483

starksm64 opened this issue Aug 21, 2024 · 3 comments
Assignees
@scottmarlow
Labels
11.0 Issues related to the Jakarta EE 11 Platform TCK release

Comments

@starksm64
Copy link
Contributor

No description provided.

@starksm64 starksm64 converted this from a draft issue Aug 21, 2024
@starksm64 starksm64 moved this to Ready to Assign in Jakarta EE11 TCK Release Aug 21, 2024
@scottmarlow scottmarlow self-assigned this Sep 4, 2024
@gurunrao gurunrao added the 11.0 Issues related to the Jakarta EE 11 Platform TCK release label Oct 4, 2024
@scottmarlow
Copy link
Contributor

Before running the OpenRewrite recipe, rename the Signature test client source name to match the filter.

@scottmarlow
Copy link
Contributor

The current EE 10 Platform TCK Signature tests run in Web container, EJB container + appclient container (as per vehicles.properties):
com/sun/ts/tests/signaturetest/javaee = ejb servlet jsp appclient

With regard to servlet versus jsp, I think both validate that the Web container exports the correct SPEC API classes to the deployed application. I suppose that the implemenations JSP deployer could have a bug but we should consider if its worth adding the JSP case after covering ejb/servlet/appclient cases.

@scottmarlow
Copy link
Contributor

EE 10 deployment contents

app client container test

JavaEESigTest_appclient_vehicle.ear contents

META-INF/MANIFEST.MF
lib/sigtest.jar
JavaEESigTest_appclient_vehicle_client.jar

JavaEESigTest_appclient_vehicle_client.jar contents

META-INF/MANIFEST.MF
META-INF/application-client.xml
com/sun/ts/lib/harness/EETest$Fault.class
com/sun/ts/lib/harness/EETest$SetupException.class
com/sun/ts/lib/harness/EETest.class
com/sun/ts/lib/harness/ServiceEETest.class
com/sun/ts/tests/common/vehicle/EmptyVehicleRunner.class
com/sun/ts/tests/common/vehicle/VehicleClient.class
com/sun/ts/tests/common/vehicle/VehicleRunnable.class
com/sun/ts/tests/common/vehicle/VehicleRunnerFactory.class
com/sun/ts/tests/signaturetest/ApiCheckDriver.class
com/sun/ts/tests/signaturetest/PackageList.class
com/sun/ts/tests/signaturetest/SigTest.class
com/sun/ts/tests/signaturetest/SigTestData.class
com/sun/ts/tests/signaturetest/SigTestDriver.class
com/sun/ts/tests/signaturetest/SigTestEE.class
com/sun/ts/tests/signaturetest/SigTestResult.class
com/sun/ts/tests/signaturetest/SignatureTestDriver$SignatureFileInfo.class
com/sun/ts/tests/signaturetest/SignatureTestDriver.class
com/sun/ts/tests/signaturetest/SignatureTestDriverFactory.class
com/sun/ts/tests/signaturetest/javaee/JavaEESigTest$Containers.class
com/sun/ts/tests/signaturetest/javaee/JavaEESigTest.class

Servlet container test

JavaEESigTest_servlet_vehicle.ear contents

META-INF/MANIFEST.MF
JavaEESigTest_servlet_vehicle_web.war

JavaEESigTest_servlet_vehicle_web.war contents

META-INF/MANIFEST.MF
WEB-INF/classes/com/sun/ts/tests/signaturetest/javaee/JavaEESigTest$Containers.class
WEB-INF/classes/com/sun/ts/tests/signaturetest/javaee/JavaEESigTest.class
WEB-INF/classes/com/sun/ts/lib/harness/EETest$Fault.class
WEB-INF/classes/com/sun/ts/lib/harness/EETest$SetupException.class
WEB-INF/classes/com/sun/ts/lib/harness/EETest.class
WEB-INF/classes/com/sun/ts/lib/harness/ServiceEETest.class
WEB-INF/classes/com/sun/ts/tests/common/vehicle/VehicleClient.class
WEB-INF/classes/com/sun/ts/tests/common/vehicle/VehicleRunnable.class
WEB-INF/classes/com/sun/ts/tests/common/vehicle/VehicleRunnerFactory.class
WEB-INF/classes/com/sun/ts/tests/common/vehicle/servlet/ServletVehicle.class
WEB-INF/classes/com/sun/ts/tests/signaturetest/ApiCheckDriver.class
WEB-INF/classes/com/sun/ts/tests/signaturetest/PackageList.class
WEB-INF/classes/com/sun/ts/tests/signaturetest/SigTest.class
WEB-INF/classes/com/sun/ts/tests/signaturetest/SigTestData.class
WEB-INF/classes/com/sun/ts/tests/signaturetest/SigTestDriver.class
WEB-INF/classes/com/sun/ts/tests/signaturetest/SigTestEE.class
WEB-INF/classes/com/sun/ts/tests/signaturetest/SigTestResult.class
WEB-INF/classes/com/sun/ts/tests/signaturetest/SignatureTestDriver$SignatureFileInfo.class
WEB-INF/classes/com/sun/ts/tests/signaturetest/SignatureTestDriver.class
WEB-INF/classes/com/sun/ts/tests/signaturetest/SignatureTestDriverFactory.class
WEB-INF/lib/sigtest.jar
WEB-INF/web.xml

EJB test currently using appclient container

TODO: look into running from Servlet vehicle instead of from appclient container to avoid spending time on remote ejb lookup problems from app client container.

JavaEESigTest_ejb_vehicle.ear contents

META-INF/MANIFEST.MF
JavaEESigTest_ejb_vehicle_client.jar
JavaEESigTest_ejb_vehicle_ejb.jar
lib/sigtest.jar

JavaEESigTest_ejb_vehicle_client.jar contents

META-INF/MANIFEST.MF
META-INF/application-client.xml
com/sun/ts/lib/harness/EETest$Fault.class
com/sun/ts/lib/harness/EETest$SetupException.class
com/sun/ts/lib/harness/EETest.class
com/sun/ts/lib/harness/ServiceEETest.class
com/sun/ts/tests/common/vehicle/EmptyVehicleRunner.class
com/sun/ts/tests/common/vehicle/VehicleClient.class
com/sun/ts/tests/common/vehicle/VehicleRunnable.class
com/sun/ts/tests/common/vehicle/VehicleRunnerFactory.class
com/sun/ts/tests/common/vehicle/ejb/EJBVehicleHome.class
com/sun/ts/tests/common/vehicle/ejb/EJBVehicleRemote.class
com/sun/ts/tests/common/vehicle/ejb/EJBVehicleRunner.class

JavaEESigTest_ejb_vehicle_ejb.jar contents

META-INF/MANIFEST.MF
com/sun/ts/tests/signaturetest/javaee/JavaEESigTest$Containers.class
com/sun/ts/tests/signaturetest/javaee/JavaEESigTest.class
com/sun/ts/lib/harness/EETest$Fault.class
com/sun/ts/lib/harness/EETest$SetupException.class
com/sun/ts/lib/harness/EETest.class
com/sun/ts/lib/harness/ServiceEETest.class
com/sun/ts/tests/common/vehicle/VehicleClient.class
com/sun/ts/tests/common/vehicle/VehicleRunnable.class
com/sun/ts/tests/common/vehicle/VehicleRunnerFactory.class
com/sun/ts/tests/common/vehicle/ejb/EJBVehicle.class
com/sun/ts/tests/common/vehicle/ejb/EJBVehicleHome.class
com/sun/ts/tests/common/vehicle/ejb/EJBVehicleRemote.class
com/sun/ts/tests/signaturetest/ApiCheckDriver.class
com/sun/ts/tests/signaturetest/PackageList.class
com/sun/ts/tests/signaturetest/SigTest.class
com/sun/ts/tests/signaturetest/SigTestData.class
com/sun/ts/tests/signaturetest/SigTestDriver.class
com/sun/ts/tests/signaturetest/SigTestEE.class
com/sun/ts/tests/signaturetest/SigTestResult.class
com/sun/ts/tests/signaturetest/SignatureTestDriver$SignatureFileInfo.class
com/sun/ts/tests/signaturetest/SignatureTestDriver.class
com/sun/ts/tests/signaturetest/SignatureTestDriverFactory.class
META-INF/ejb-jar.xml

JSP/Server Pages contents

JavaEESigTest_jsp_vehicle.ear contents

META-INF/MANIFEST.MF
JavaEESigTest_jsp_vehicle_web.war

JavaEESigTest_jsp_vehicle_web.war contents

jsp_vehicle.jsp
META-INF/MANIFEST.MF
WEB-INF/classes/com/sun/ts/tests/signaturetest/javaee/JavaEESigTest$Containers.class
WEB-INF/classes/com/sun/ts/tests/signaturetest/javaee/JavaEESigTest.class
WEB-INF/classes/com/sun/ts/lib/harness/EETest$Fault.class
WEB-INF/classes/com/sun/ts/lib/harness/EETest$SetupException.class
WEB-INF/classes/com/sun/ts/lib/harness/EETest.class
WEB-INF/classes/com/sun/ts/lib/harness/ServiceEETest.class
WEB-INF/classes/com/sun/ts/tests/common/vehicle/VehicleClient.class
WEB-INF/classes/com/sun/ts/tests/common/vehicle/VehicleRunnable.class
WEB-INF/classes/com/sun/ts/tests/common/vehicle/VehicleRunnerFactory.class
WEB-INF/classes/com/sun/ts/tests/signaturetest/ApiCheckDriver.class
WEB-INF/classes/com/sun/ts/tests/signaturetest/PackageList.class
WEB-INF/classes/com/sun/ts/tests/signaturetest/SigTest.class
WEB-INF/classes/com/sun/ts/tests/signaturetest/SigTestData.class
WEB-INF/classes/com/sun/ts/tests/signaturetest/SigTestDriver.class
WEB-INF/classes/com/sun/ts/tests/signaturetest/SigTestEE.class
WEB-INF/classes/com/sun/ts/tests/signaturetest/SigTestResult.class
WEB-INF/classes/com/sun/ts/tests/signaturetest/SignatureTestDriver$SignatureFileInfo.class
WEB-INF/classes/com/sun/ts/tests/signaturetest/SignatureTestDriver.class
WEB-INF/classes/com/sun/ts/tests/signaturetest/SignatureTestDriverFactory.class
client.html
WEB-INF/lib/sigtest.jar
WEB-INF/web.xml

@scottmarlow scottmarlow moved this from Ready to Assign to In progress in Jakarta EE11 TCK Release Jan 22, 2025
@scottmarlow scottmarlow mentioned this issue Jan 23, 2025
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@scottmarlow scottmarlow

Labels
11.0 Issues related to the Jakarta EE 11 Platform TCK release
Projects
Jakarta EE11 TCK Release
Status: In progress
Milestone
No milestone
Development

No branches or pull requests
3 participants
@starksm64 @scottmarlow @gurunrao