-
Notifications
You must be signed in to change notification settings - Fork 119
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Preview iframes blocked in Chrome 33 #100
Comments
Are you serving the file or are you accessing it through the file:// directive? Can you also tell me what the src attribute of the iframe is? |
I'm serving these files via a web server. The src attr is I found I can get this to work in Chrome Canary by commenting out a line in // if (this.contentDocument) support.sameOriginDataUri = true; But here's the interesting part... it's not the fact that we're setting if (this.contentDocument) {
// support.sameOriginDataUri = true;
} ...things are still broken. But if I comment out the check: // if (this.contentDocument) {
// support.sameOriginDataUri = true;
// } ...then it works! (In Chrome 33, but still not in Firefox). |
What happens if you And What error is the |
Modified code: var support = { sameOriginDataUri: false };
console.log("*** ABout to see this!")
console.log(this)
if (this.contentDocument) support.sameOriginDataUri = true; Chrome 30 (where the preview iframes render correctly): Chrome 33 (where the preview iframes do not render correctly):
Looks like both versions of Chrome are complaining about a security violation, though the error is slightly different. See above. |
I'm seeing the issue now as well on the demo site. It's the iframes that are generated at runtime that are doing it. The html is generated by the app rather than coming from an external resource, so they're described as I'm going to have to find some time to investigate this. We either need to find another way to generate these iframes on the front-end or start serving them from the back-end. Please let me know if you find any solutions to this yourself. |
#91 is related |
Code for detecting if browser enforced same origin policy for iframes using different src protocols was not working correctly and an exception was being thrown. This meant that some browsers were not able to generate iframes for the examples.
Code for detecting if browser enforced same origin policy for iframes using different src protocols was not working correctly and an exception was being thrown. This meant that some browsers were not able to generate iframes for the examples.
Code for detecting if browser enforced same origin policy for iframes using different src protocols was not working correctly and an exception was being thrown. This meant that some browsers were not able to generate iframes for the examples.
Using Chrome Canary (version 33.0.1703.0) on the styledocco sample page:
http://jacobrask.github.io/styledocco/styledocco/examples/styledocco/docs.html
Getting this error, and the preview iframes are not getting appended to the DOM.
Screenshot:
I also notice a similar issue happening with my own styleguides, using Firefox 25, but for some reason the styledocco example works in Firefox...
The text was updated successfully, but these errors were encountered: