update LWJGLX (AWT) from 0.1.8 to 0.2.3 #2373
Conversation
JNightRider
changed the title
|
It looks like this is the first PR that has failed from the new screenshot tests. However I don't think there's anything inherently wrong with this PR, so I will look into it and see how to resolve it as soon as I can. |
|
If you get a chance, could you take a look at the failed screenshot test and let me know if it looks like it is something to be worried about? It appears there is nothing wrong and the rest of the tests passed, so the PR should be good to merge. However this is the first instance I have seen where the new test fails, so I am curious to hear your analysis of the situation. Thanks! |
This is the problem. The screenshot tests all fail because this change (on its own) seems to break JME. I tested this on my own pipeline and it consistently fails. But merge pull request 2371 into it and it passes just fine. So the screenshot tests are telling us the same as what I now notice JNightRider is saying; this PR is dependent on pull request 2371. It is interesting (and kind of validating) that only the screenshot tests noticed the breakage My suggestion:
(I've used master in my suggestion, I'm not that familiar with the JME release process, by master I mean whatever branch is having the release built into it, master or otherwise) |
|
For this PR to pass the test, I think it is better to merge #2371 first and then update this PR. |
This PR updates the lwjglx-awt library to the latest version (V0.2.3). In this new version, an error that was reported in the forum has been solved (correction in lwjgl-awt)
I would like to inform you that these changes are related to PR #2371, that is; that this PR depends on PR #2371 so that AWT does not break when updating LWJGL3.