Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Request routing should first match on path, then on request method #24

Open
ivanr opened this issue Oct 28, 2018 · 0 comments
Open

Request routing should first match on path, then on request method #24

ivanr opened this issue Oct 28, 2018 · 0 comments
Assignees
@ivanr
Labels
bug

Comments

@ivanr
Copy link
Owner

ivanr commented Oct 28, 2018 •
edited
Loading

We currently route requests first based on the request method, then based on path. This leads to a problem when the combination of method and path in the request doesn't match the expected route, most likely leading to a 404. This is confusing if the path is correct, because we should respond with a 405.
@ivanr ivanr added the bug label Oct 28, 2018
@ivanr ivanr self-assigned this Oct 28, 2018
ivanr added a commit that referenced this issue Oct 30, 2018
@ivanr
Added an optional feature that forces a 405 response if we match the …
e31224b 
…path but don't match the request method. #24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ivanr ivanr

Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ivanr