-
Notifications
You must be signed in to change notification settings - Fork 0
/
Copy pathCHANGELOG
224 lines (190 loc) · 8.43 KB
/
CHANGELOG
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
Contains changelog of neo-2 code. Tags are also included.
Note: use git tag --list to get a list of available tags.
Added [for new features]
Changed [changes in existing functionality]
Deprecated [soon-to-be removed features]
Removed [now removed features]
Fixed [any bug fixes]
Security [in case of vulnerabilities]
Added [for new features]
- Basis for NBI.
- Relativistic effects for PAR version
Changed [changes in existing functionality]
- Internal cutoff for integration to infinity may be lowered.
- Executables have now name with part based on which version of the
code (par or ql) they are from.
Deprecated [soon-to-be removed features]
Removed [now removed features]
Fixed [any bug fixes]
Security [in case of vulnerabilities]
228bcd397232e0e27ced0be43fb8b68738afbb00 ; fix_sign_geometry
An inconsistency in the handling of signs was found and fixed. Sergei
provided the following two comments (originaly within the code):
!------------------------------------Begin comment 1 from 12.07.2023------------------------------
! Sergei:
! Status for 12.07.2023:
! Consequencies of the reversed sign of $h^\varphi$ ("h_phi_mf"):
!
! Distribution function $\bar f$ computed with replacement $h^\varphi \rightarrow - h^\varphi$
! is related to the distribution function $f$ computed with the normal sign of $h^\varphi$
! as follows:
! 1) for the sources $A_1$ and $A_2$ (gradient drive) $\bar f(v_\parallel) = f(-v_\parallel)$
! 2) for the source $A_3$ (inductive electric field drive) $\bar f(v_\parallel) = - f(-v_\parallel)$
!
! Source terms $\bar q$ used for the computation of transport coefficients (convolution with $f$)
! are related to original source terms $q$ as follows:
! 1) for the sources $A_1$ and $A_2$ (gradient drive)
! $\bar q(v_\parallel) = \bar q(-v_\parallel) = - q(v_\parellel) = - q(-v_\parallel)$
! 2) for the source $A_3$ (inductive electric field drive)
! $\bar q(v_\parallel) = - bar q(-v_\parallel) = - q(v_\parallel) = q(-v_\parallel)$
!
! Consequence for the intermediate transport coefficient $Q_{jk}$=qflux(j,k) are the following:
! $\bar Q_{11} = - Q_{11}$, $\bar Q_{22} = - Q_{22}$, $\bar Q_{33} = - Q_{33}$
! $\bar Q_{13} = Q_{13}$, $\bar Q_{31} = Q_{31}$, $\bar Q_{23} = Q_{23}$, $\bar Q_{32} = Q_{32}$
!
! Minus sign for the diagonal coeficients is OK - intermediate coefficients should keep the sign
! of $h^\varphi$ because they are divided then by the integral y(6) = $\int \rd\varphi / h^\varphi$
! Not OK is unchanged sign of cross coefficients (bootstrap, Ware pinch).
!
! Changes from 12.07.2023:
! We multiply source term for drive $A_3$ with $sign(h^\varphi)$=sign_of_bphi (in addition to the elimination
! of the sign of h_phi_nfl made previously). This is done for both, source term in the equation and
! convolution term for the computation of fluxes.
! With this, for all drives, $A_1$, $A_2$ and $A_3$, distribution function fulfills
! $\bar f(v_\parallel) = f(-v_\parallel)$
! and the sources fulfill
! $\bar q(v_\parallel) = - q(- v_\parallel)$
! Respectively, all transport coefficients fulfill
! $\bar Q_{jk} = - Q_{jk}$
! All respective changes in the code are marked with "<= Sergei 12.07.2023"
!------------------------------------End comment 1 from 12.07.2023------------------------------
!------------------------------------Begin comment 2 from 12.07.2023------------------------------
! Sergei:
! Status 12.07.2023:
! 1) Definition of geodesic curvature in both, unperturbed and perturbed problems assumes that
! metric determinant of Boozer coordinates $(s,\vartheta,\varphi)$ is given by
!
! $\sqrt{g} = \sigma_g \psi^a (\iota B_\vartheta + B_\varphi) / B^2 = \sigma_g \psi^a /B^\varphi$ (A1),
!
! $with sigma_g=1$.
! In some cases $\sigma_g$ may have an opposite sign and lead to the wrong sign of geodesic curvature.
! Namely, the original definition of the unperturbed geodesic curvature defined in usual (non-aligned)
! Boozer coordinates $(s,\vartheta,\varphi)$ through the metric determinant (this definition does always
! have a proper sign) is the following:
!
! $\sqrt{g}|\nabla s| = - \frac{B_\varphi}{B_0^2 \sqrt{g}}\difp{B_0}{\vartheta}$.
!
! In the code below, this geodesic curvature is defined as follows:
!
! $\sqrt{g}|\nabla s| = - \frac{B_\varphi}{\psi^a (B_\varphi+\iota B_\vartheta)} \difp{B_0}{\vartheta}$.
!
! Comparison of two expressions leads to Eq.(A1) with $\sigma_g=1$.
!
! Consequently, all cross transport coefficients $(D_{13}, D_{31}, D_{23}, D_{32})$ have an opposite
! sign in case $\sigma_g = -1$. Fixed by correction 1 below.
!
! 2) Toroidal ExB precession is defined in "ntv_mod" using explicitly $\sqrt{g}$. Therefore sqrt(g) sign
! problem does not appear for this precession. Magnetic precession is defined via spelled $\sqrt{g}$
! with $\sigma_g=1$. Fixed similarly by correction 2 below.
! Hint for the precession sign checks: ExB precession is in co-current direction for E_r>0,
! magnetic precession for deeply trapped ions (at the outboard) is in co-current direction.
! This is independent of the sign of the toroidal magnetic field (because precession signs are
! determined by the sign of poloidal field)
!
!
! Changes 12.07.2023:
! 1) We correct the geodesic curvature sign by using directly quantity
! "boozer_isqrg" = $1/sqrt{g}$ available in the module "neo_magfie" by multiplying "scalefac_kG"
! with an appropriate sign factor $\sigma_g = \sign(\psi^a B_\varphi / \sqrt{g})$
!
! 2) We correct magnetic precession sign by multiplying hatOmegaB by the same factor $\sigma_g$ as above.
!
!------------------------------------End comment 2 from 12.07.2023------------------------------
4c15fa6dcac129c645ffa1091736b563098a361c ; module-rewrite_common
Moved modules in common to own files. Exception for modules that are
used only in the file in which they are defined.
9558c15a468a509bd11cde9fb05eef31bf21e904
Introduced adaption of x_cutoff.
0.5.5
0b97c4ec67f89449879933327fb36c6bd5765828
first draft for nbi part
0.5.4
4249957b68cfcfc3c3b20e3bb2cf4a46aa2ac345
Stable version used for a publication?
This version of the code is tagged because it was used for a publication
and should be easily acessible.
0.5.3
152545e684792fdaa901b9f4cfdab3abc0d8ce3d
Old stable version?
Version used for example by Matyas.
0.5.2
k_coefficient_in_par 0a1d1d742db80074a741a776e1ed714217fd1302
Computation of k coefficient in NEO-2-PAR version
0.5.1
multispecies 7ddb095bbe2ccd4dbe73526047026477de7f9546
Support for multi-species computations
0.5
merge_magnetic_routines 8b6845ef60e7f7e90d1970979b130b22b6bec1a8
Final merge of magnetics routines.
0.4.1
relativistic_collision_operator 10fc644158fd701f31d5bc21f7979b6644adf1df
Support for relativistic collision operator (for Braams/Karney and high
order Legendre expansion). Results benchmarked to SYNCH.
0.4
merging_of_codes dcb6855c2edd4a6b23d51e73e16dc0de00350c4a
Merging of PAR and QL codes
0.3
first_modular_version 551d2c38cd47f5c720ef07abd062c54895b839dd
first modular version
0.2.1
hdf5_support fbf60e2167edf34900607f5926e9a49941b6f2a8
HDF5 Support
0.2
arbitrary_base_functions 227d735fb50bf3a334c106fd1603d0cc164d8c14
arbitrary base functions
0.1
initial_release_ql 7928e9a6be17852982dd90e5b804a1e6887934fa
initial release of QL branch.
0.0ql
initial_release_par dcd0a68b23b4c5e57414d63c96f434c7fece4048
initial release of PAR branch.
0.0par
2013-07-30.1
Added [new features]
Changed [changes in existing functionality]
- Improvements in makesystem
Deprecated [soon-to-be removed features]
Removed [now removed features]
- remove some not needed files
Fixed [any bug fixes]
Security [in case of vulnerabilities]
2013-07-19.1
Added [for new features]
Changed [changes in existing functionality]
- Only master process writes files.
Deprecated [soon-to-be removed features]
Removed [now removed features]
Fixed [any bug fixes]
Security [in case of vulnerabilities]
2013-07-18.1
Added [for new features]
Changed [changes in existing functionality]
- New versioning convention.
Deprecated [soon-to-be removed features]
Removed [now removed features]
Fixed [any bug fixes]
Security [in case of vulnerabilities]
v0.1.2b ?
Added [for new features]
Changed [changes in existing functionality]
Deprecated [soon-to-be removed features]
Removed [now removed features]
Fixed [any bug fixes]
Security [in case of vulnerabilities]
v2.1.0 ?
Added [for new features]
Changed [changes in existing functionality]
Deprecated [soon-to-be removed features]
Removed [now removed features]
Fixed [any bug fixes]
Security [in case of vulnerabilities]