Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Thread abuse #12

Open
itoshkov opened this issue Aug 25, 2017 · 0 comments
Open

Thread abuse #12

itoshkov opened this issue Aug 25, 2017 · 0 comments

Comments

@itoshkov
Copy link
Owner

The code starts new threads whenever it feels like it, which makes it very hard to reason about it. For example if you click on a button in the GUI the code would start a new thread to handle it, even if the action is just to set a new value to a variable.

It should use two main threads: one for the lower level emulator and one for the GUI. (If there is a GUI at all. It could run in non-interactive mode.)

It may be good to write the lower level emulators to run on multiple threads, so they can make a better use of the real CPU cores. But I think this is secondary to making work correctly and being easy to maintain.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant