Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation #14

Open
jenpaff opened this issue Jan 31, 2025 · 1 comment
Open

Documentation #14

jenpaff opened this issue Jan 31, 2025 · 1 comment
Assignees
Labels
documentation Improvements or additions to documentation
Milestone

Comments

@jenpaff
Copy link
Contributor

jenpaff commented Jan 31, 2025

Document every API on README

@jenpaff jenpaff added the documentation Improvements or additions to documentation label Jan 31, 2025
@smitrajput
Copy link

smitrajput commented Feb 3, 2025

Hello,

I might be in a good position to help @Vectorized out with this issue.

Why?

I built an ERC4337-compliant wallet a while ago with

which looks like a decent overlap with this delegation contract to start with.

Plus, happened to get some good context on EIP-7702 and ithacaxyz/exp-0001 recently (outside of some general optimizoor fanboying), to realise how feature-stacked this delegation contract for next-gen accounts is, inspiring some contributions.

How?

I'd suggest starting with a simple forge-generated book of all contract docs, which would look similar to this version of superform-core hosted on my github pages. From there, I'll start adding missing docs as comments in all the contracts, with more peripheral contextual information wherever required, whose design can then be refined like Uniswap's (also created with forge-docs).

I understand that these docs are not directly in the README as you asked, so curious if this solution fits the bill and if not, how would you want me to go about it?

Essential Context

Apart from the aforementioned resources, I've skimmed the core contracts and will dive deeper after your confirmation. Please let me know other resources, context I should have before getting started (if any).

All ears to your response.

@jenpaff jenpaff added this to the v1.0 milestone Feb 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

No branches or pull requests

4 participants