Skip to content
This repository was archived by the owner on Feb 12, 2024. It is now read-only.

Streamlining IPFS Config #3390

Closed
Gozala opened this issue Nov 12, 2020 · 1 comment
Closed

Streamlining IPFS Config #3390

Gozala opened this issue Nov 12, 2020 · 1 comment
Assignees
Labels
exploration kind/discussion Topical discussion; usually not changes to codebase kind/wontfix-migration-available

Comments

@Gozala
Copy link
Contributor

Gozala commented Nov 12, 2020

#3365 spawned discussions around config. I think deserves a separate conversation and possibly pull request based on consensus.

Right now there are various assumptions made about the config across the code base e.g.

  • Some code paths assume that config will have certain properties e.g. Addresses or Discovery.
  • Other code paths assume that it my not have anything at all.
  • Some other code paths assume that merging incomplete config with some other (possibly invalid / incomplete config e.g read from file) will result in complete config.

All this makes it very difficult to encode invariants in type checker and uphold them as well. I would like to propose isolating the config parsing, merging access with defaults etc... into separate module that deals with all this so all the code paths can be be free of those concerns and be valid.

@Gozala Gozala added kind/discussion Topical discussion; usually not changes to codebase need/triage Needs initial labeling and prioritization labels Nov 12, 2020
@achingbrain achingbrain added exploration and removed need/triage Needs initial labeling and prioritization labels Nov 13, 2020
@SgtPooki SgtPooki moved this to 🥞 Todo in js-ipfs deprecation May 17, 2023
@SgtPooki
Copy link
Member

js-ipfs is being deprecated in favor of Helia. You can #4336 and read the migration guide.

Please feel to reopen with any comments by 2023-06-02. We will do a final pass on reopened issues afterward (see #4336).

This issue is most likely resolved in Helia, please try it out!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
exploration kind/discussion Topical discussion; usually not changes to codebase kind/wontfix-migration-available
Projects
No open projects
Status: Done
Development

No branches or pull requests

3 participants