Skip to content
This repository was archived by the owner on Feb 12, 2024. It is now read-only.

Update pre-async/await js-ipfs usage across PL repos #3104

Closed
andrew opened this issue Jun 19, 2020 · 4 comments
Closed

Update pre-async/await js-ipfs usage across PL repos #3104

andrew opened this issue Jun 19, 2020 · 4 comments
Labels
kind/discussion Topical discussion; usually not changes to codebase need/author-input Needs input from the original author

Comments

@andrew
Copy link
Contributor

andrew commented Jun 19, 2020

There are still a number of repos across ipfs/ipld/libp2p that are using js-ipfs < 0.41 that can be confusing to people looking for examples:

repo version manifest file issue/pr
ipfs-shipyard/ipfs-companion 0.40.0 package.json ipfs/ipfs-companion#811
ipld/js-ipld-graph-builder ^0.32.3 package.json ipld/js-ipld-graph-builder#40
ipfs-shipyard/ipfs-share-files ^0.33.1 package.json ipfs-shipyard/ipfs-share-files#75
ipfs/benchmarks ^0.34.0 tests/package.json ipfs/benchmarks#276
ipfs-shipyard/ipld-explorer ^0.34.4 package.json ipld/explore.ipld.io#65
ipfs-shipyard/js-idm-wallet git://github.com/satazor/js-ipfs.git#ipfs-camp package.json
ipfs-shipyard/js-idm-client git://github.com/satazor/js-ipfs.git#ipfs-camp package.json
libp2p/js-libp2p ~0.34.4 examples/delegated-routing/package.json libp2p/js-libp2p#507
ipfs-shipyard/ipfs-npm-registry-mirror ~0.36.3 packages/common/package.json ipfs-shipyard/ipfs-npm-registry-mirror#17
@andrew andrew added the need/triage Needs initial labeling and prioritization label Jun 19, 2020
@oed
Copy link
Contributor

oed commented Jun 22, 2020

ipfs-shipyard/ipfs-pubsub-1on1#11

@achingbrain achingbrain added kind/discussion Topical discussion; usually not changes to codebase and removed need/triage Needs initial labeling and prioritization labels Jun 22, 2020
@achingbrain
Copy link
Member

@andrew could you open issues on the affected repos? Their owners may not check this issue so likely won't know that they should update.

If they aren't maintaining them any more, they should probably be archived or at least a big note should be put in the readme.

Also, some repos have been updated, can you update this table occasionally?

@achingbrain achingbrain added the need/author-input Needs input from the original author label Jul 17, 2020
@andrew
Copy link
Contributor Author

andrew commented Sep 22, 2020

I've updated the table, removed rows that have been upgraded and added links to PRs that will update js-ipfs

@lidel
Copy link
Member

lidel commented May 24, 2021

Based on triage discussion, closing as stale: assuming if a project did not update by now, either there is an unrelated blocker, or project is not important enough/maintained.

@lidel lidel closed this as completed May 24, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
kind/discussion Topical discussion; usually not changes to codebase need/author-input Needs input from the original author
Projects
None yet
Development

No branches or pull requests

4 participants