Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

copy public URL on anchor context #592

Open
djdv opened this issue Sep 20, 2018 · 1 comment
Open

copy public URL on anchor context #592

djdv opened this issue Sep 20, 2018 · 1 comment
Labels
kind/bug A bug in existing code (including security flaws) status/in-progress In progress

Comments

@djdv
Copy link

djdv commented Sep 20, 2018

Unfortunately, I don't know when this stopped working, or if it's actually intended to work this way.
But at some point previously, I could right-click anchors and copy their specific public url.
Now, when I do the same, it copies the public url to the current path, without the anchor's target.

e.g.
This
companion context copy
Should put
http://ipfs.io/ipfs/QmWn4vJepGcAEmT36FDL6ca1RxSXiuca9Ew8pb7RZGKbq4/symlink-tree.tar.xz
on the clipboard, but I end up with just
http://ipfs.io/ipfs/QmWn4vJepGcAEmT36FDL6ca1RxSXiuca9Ew8pb7RZGKbq4

Edit:
For reference, I'm getting this on Firefox and Vivaldi, with the latest stable and beta.

@lidel
Copy link
Member

lidel commented Sep 20, 2018

Ah, yes, we recently noticed context actions use shady heuristic that does not work for all use cases :)
Fixing one thing broke the other.

I'm trying to deliver what you want and a little bit more in this PR:
#585 (comment) ← would appreciate some feedback

@lidel lidel added kind/bug A bug in existing code (including security flaws) UX labels Sep 20, 2018
@lidel lidel added status/ready Ready to be worked status/in-progress In progress and removed status/ready Ready to be worked labels Sep 22, 2018
@galargh galargh moved this to To do in IPFS-GUI (PL EngRes) Sep 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug A bug in existing code (including security flaws) status/in-progress In progress
Projects
No open projects
Status: Needs Grooming
Development

No branches or pull requests

3 participants