Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend image_flip to cope with other image formats #85

Open
fmessmer opened this issue Sep 26, 2017 · 3 comments · May be fixed by #93
Open

Extend image_flip to cope with other image formats #85

fmessmer opened this issue Sep 26, 2017 · 3 comments · May be fixed by #93
Assignees

Comments

@fmessmer
Copy link
Member

As found during ipa320/cob_robots#720 (review), image_flip currently is only able to flip images that have format CV_8UC3

@fmessmer
Copy link
Member Author

idea from @ipa-bnm
additionally, it would make sense to implement image_flip in a lazy matter, i.e. only process and publish messages if there are other nodes sunscribed to the outgoing messages

@ipa-rmb
Copy link
Contributor

ipa-rmb commented Oct 27, 2017

Yes good idea. If we are lucky, one of my students will have time during the next 2 months to implement these requests.

@ipa-rmb
Copy link
Contributor

ipa-rmb commented Nov 7, 2017

When .at(v,u) is used for access then we could have a typedef mapping depending on 8,16,32,64 bit, data type (uchar, char, short, ushort, uint, int, int64?, float, double) and channels (1,2,3,4).

We can do something similar for the case with pointers and template/typedef the pointer type (or just use the slower .at operator likewise).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants