[travis] improvements and extensions

[fmessmer]

@ipa-fez @ipa-jba @ipa-rmb @ipa-fmw @ipa-mig @ipa-nhg @ipa-mdl @fmessmer FYI

I'll start this issue for discussion that should lead to an improved/extended default .travis.yml that we use in all our repos (see list below).
I suggest to first discuss which new features are to be added to the new default .travis.yml and then provide PRs for all affected repos in a torrent for consistency!

New features to be added:

• get rid of jade testing - once and for all - we do not support it...safes some jobs on the travis servers
• enable compiler warnings as errors (as done by @ipa-fez e.g. in https://github.com/ipa320/ipa_navigation_driver/pull/40)
• enable testing against releases, i.e. add entries to the CI matrix UPSTREAM_WORKSPACE=file to test with .rosinstall file + UPSTREAM_WORKSPACE=debian (default) to test against releases (I don't think we need to make another distinction against ROS_REPO=ros and ROS_REPO=ros-shadow-fixed
• maybe we can even embed (Xdev?) jobs from the ROS build farm, e.g. like Idev__cob_robots__XXX
• enable UPSTREAM/DOWNSTREAM testing see [travis] setup downstream tests #39 (as tested in [DO_NOT_MERGE] testing industrial_ci feature branch cob_robots#680 - **NOTE: this is not yet available in industrial_ci/master)
• anything else?
• any other feature desired/helpful from https://github.com/ros-industrial/industrial_ci/blob/master/doc/index.rst#advanced-usage? e.g. CATKIN_LINT!

Who steps forward and is willing to provide a suggestive PR against care-o-bot, i.e. this, repo?

---

• care-o-bot
• cob_android
• cob_calibration_data
• cob_command_tools
• cob_common
• cob_control
• cob_docking
• cob_driver
• cob_environments
• cob_extern
• cob_gazebo_plugins
• cob_hand
• cob_manipulation
• cob_navigation
• cob_perception_common
• cob_robots
• cob_simulation
• cob_substitute
• cob_supported_robots
• schunk_modular_robotics
• schunk_robots
• sick_flexisoft

NAV-REPOS:

• ipa_navigation
• ipa_navigation_common
• ipa_navigation_driver
• ipa_navigation_localization
• ipa_navigation_perception
• ipa_navigation_planning
• ipa_navigation_sandbox
• cob_karto
• ...

PERCEPTION-REPOS:

• cob_environment_perception
• cob_object_perception
• cob_people_perception
• experimental pkgs?

MSH-REPOS:

• msh
• msh_common
• msh_gui
• msh_voice_control
• ....

Please add repos in case I missed one...

[mathias-luedtke]

enable compiler warnings as errors (as done by @ipa-fez e.g. in ipa320/ipa_navigation_driver#40)

It is okay to add it to travis as well, but I recommend to set this for every (c++) package.
This way the user gets the error immediately.

[ipa-fez]

It is okay to add it to travis as well, but I recommend to set this for every (c++) package.
This way the user gets the error immediately.

Do you mean directly in the CMakeLists.txt @ipa-mdl?

[ipa-rmb]

Though I like getting rid of warnings, I fear we cannot eliminate all warnings that originate from PCL and we have no means to fix that (multiple dependencies to other libraries). Hence I would suggest that everyone who can afford turning this on, should do it in cmake.

[mgruhler]

@ipa-mdl Do you know of a way that catkin_lint does not treat this as an error? I.e. not changing the CMAKE_CXX_FLAGS?

@ipa-fmw Additionally I only see unit tests...

[mathias-luedtke]

@ipa-mig: Please, don't mess with CMAKE_CXX_FLAGS in CMakeLists.txt; catkin_lint might even warn you (if not, this should be added).
Per-package options should be set with add_compile_options (please set cmake_minimum_required(VERSION 2.8.12)). Alternative for CMake < 2.8.12 (e.g. < ubuntu 14.04): add_definitions

@ipa-rmb: The warnings we'd like to address should not occur in PCL or any other common library.

[ipa-rmb]

Ah yes, these warnings should probably not occur and are serious errors.

I agree with removing jade.

[mgruhler]

@ipa-mdl I had no intention to do so. As I said, catkin_lint treats this as an error. I forgot about add_compile_options. Shame on me ;-)

…

-------- Originalnachricht -------- Betreff: Re: [ipa320/care-o-bot] [travis] improvements and extensions (#45) Von: Mathias Lüdtke <[email protected]> An: ipa320/care-o-bot <[email protected]> Cc: "Gruhler, Matthias" <[email protected]>,Mention <[email protected]> @ipa-mig<https://github.com/ipa-mig>: Please, don't mess with CMAKE_CXX_FLAGS<http://docs.ros.org/jade/api/catkin/html/user_guide/standards.html> in CMakeLists.txt; catkin_lint might even warn you (if not, this should be added). Per-package options should be set with add_compile_options<https://cmake.org/cmake/help/v3.0/command/add_compile_options.html> (please set cmake_minimum_required(VERSION 2.8.12)). Alternative for CMake < 2.8.12 (e.g. < ubuntu 14.04): add_definitions<https://cmake.org/cmake/help/v3.0/command/add_definitions.html> @ipa-rmb<https://github.com/ipa-rmb>: The warnings we'd like to address should not occur in PCL or any other common library. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub<#45 (comment)>, or mute the thread<https://github.com/notifications/unsubscribe-auth/ABT3_Gyh6I5h6a7ZXZdmKPzqIYC27ehxks5sSa0lgaJpZM4Oj2eM>.

[fmessmer]

most packages done
@ipa-rmb took care of perception repos
I'll leave nav repos to @ipa320/navigation-push

[mathias-luedtke]

@ipa-fxm: if you don't set ROS_REPOSITORY_PATH or ROS_REPO, the shadow-fixed repository will be used.

[fmessmer]

if you don't set ROS_REPOSITORY_PATH or ROS_REPO, the shadow-fixed repository will be used.

I did set ROS_REPO=ros in https://github.com/ipa320/care-o-bot/pull/47/files#diff-354f30a63fb0907d4ad57269548329e3R10....or did I miss it somewhere?

[mathias-luedtke]

@ipa-fxm:
Just had a brief look and missed that you have set it globally.
Sorry for the noise!

It might make sense to use shadow-fixed by default, to detect upstream breaks earlier.
I am not sure which way to go..

[fmessmer]

debian jobs do not make too much sense for private repos like ipa_navigation and msh as they depend on other private packages that might not been released (too soon/ever)...
still I kept the syntax improvements and ROS_REPO part for msh...
I leave it to @ipa320/navigation-push to decide about ipa_navigation