Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[framework] Make use of the Clock for Timelock #4732

Closed
miker83z opened this issue Jan 9, 2025 · 4 comments
Closed

[framework] Make use of the Clock for Timelock #4732

miker83z opened this issue Jan 9, 2025 · 4 comments
Assignees
Labels
vm-language Issues related to the VM & Language Team
Milestone

Comments

@miker83z
Copy link
Contributor

miker83z commented Jan 9, 2025

  • change the unlock function to support Clock
  • consider whether to update the check_expiration_timestamp_ms with Clock
  • update tests accordingly

Could be part of Protocol Upgrade 3 with #4592

@miker83z miker83z added the vm-language Issues related to the VM & Language Team label Jan 9, 2025
@miker83z miker83z added this to the Mainnet milestone Jan 9, 2025
@alexsporn
Copy link
Member

You can target the #4741 feature branch

@miker83z
Copy link
Contributor Author

To check if changing the unlock function breaks the ledger (testnet and devnet, right now). If not, it is still worth to discuss whether we want to keep a unlock function using the epoch timestamp and an unlock_with_clock, or just keep the second one. @valeriyr @lzpap

@lzpap
Copy link
Member

lzpap commented Jan 13, 2025

Changing the function signature of a public method should definitely break the backwards compatibility @miker83z

@valeriyr
Copy link
Contributor

@miker83z @lzpap Yes, adding the clock parameter makes the iota-framework framework incompatible with version 1:

---- compatibility_tests::test_framework_compatibility stdout ----
thread 'compatibility_tests::test_framework_compatibility' panicked at crates/iota-framework-snapshot/tests/compatibility_tests.rs:37:21:
The current Iota framework 0x0000000000000000000000000000000000000000000000000000000000000002 is not compatible with version 1

I will add new functions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
vm-language Issues related to the VM & Language Team
Projects
None yet
Development

No branches or pull requests

4 participants