Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hold reconfig lock while handling transaction (#19320) · MystenLabs/sui@7c9b1d1 #4684

Closed
bingyanglin opened this issue Jan 6, 2025 · 0 comments · Fixed by #4932
Closed

Hold reconfig lock while handling transaction (#19320) · MystenLabs/sui@7c9b1d1 #4684

bingyanglin opened this issue Jan 6, 2025 · 0 comments · Fixed by #4932
Assignees
@gokhan-simsek-iota
Labels
good first issue Good for newcomers node Issues related to the Core Node team

Comments

@bingyanglin
Copy link
Contributor

Hold reconfig lock while handling transaction (#19320) · MystenLabs/sui@7c9b1d1

bug fix.
@bingyanglin bingyanglin added node Issues related to the Core Node team good first issue Good for newcomers labels Jan 6, 2025
@gokhan-simsek-iota gokhan-simsek-iota self-assigned this Jan 20, 2025
gokhan-simsek-iota added a commit that referenced this issue Jan 20, 2025
@gokhan-simsek-iota
Hold reconfig lock while handling transaction (#4684)
dadfe37 
This fixes a crash where we clear all pending locks at reconfig

(https://github.com/MystenLabs/sui/blob/dec33d0a303a7f83e778fcc5a136ab9776162e68/crates/sui-core/src/execution_cache/object_locks.rs#L121)
while trying to acquire locks for a transaction.

Without this fix, the node can reconfigure while we are trying to
acquire locks for a transaction. If `clear_locks()` linked above is
called while we are trying to call `clear_cached_locks` at
https://github.com/MystenLabs/sui/blob/74d6d564970406e1b3191a07cf207af1ab6b3356/crates/sui-core/src/execution_cache/object_locks.rs#L245,
we hit the panic at
https://github.com/MystenLabs/sui/blob/74d6d564970406e1b3191a07cf207af1ab6b3356/crates/sui-core/src/execution_cache/object_locks.rs#L160
@gokhan-simsek-iota gokhan-simsek-iota mentioned this issue Jan 20, 2025
Merged
6 tasks
gokhan-simsek-iota added a commit that referenced this issue Jan 22, 2025
@gokhan-simsek-iota
fix(node): Hold reconfig lock while handling transaction (#4684) (#4932)
d335cd3 
This fixes a crash where we clear all pending locks at reconfig

(https://github.com/MystenLabs/sui/blob/dec33d0a303a7f83e778fcc5a136ab9776162e68/crates/sui-core/src/execution_cache/object_locks.rs#L121)
while trying to acquire locks for a transaction.

Without this fix, the node can reconfigure while we are trying to
acquire locks for a transaction. If `clear_locks()` linked above is
called while we are trying to call `clear_cached_locks` at
https://github.com/MystenLabs/sui/blob/74d6d564970406e1b3191a07cf207af1ab6b3356/crates/sui-core/src/execution_cache/object_locks.rs#L245,
we hit the panic at
https://github.com/MystenLabs/sui/blob/74d6d564970406e1b3191a07cf207af1ab6b3356/crates/sui-core/src/execution_cache/object_locks.rs#L160
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gokhan-simsek-iota gokhan-simsek-iota

Labels
good first issue Good for newcomers node Issues related to the Core Node team
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Merge from upstream: fix(node): Hold reconfig lock while handling transaction iotaledger/iota
2 participants
@bingyanglin @gokhan-simsek-iota