Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WASM32 - Merge Upstream changes from iotaledger/iota into iota_sdk_abstraction/types #1446

Closed
chrisgitiota opened this issue Nov 25, 2024 · 1 comment
Assignees
Labels
Rust Related to the core Rust code. Becomes part of the Rust changelog. Wasm Related to Wasm bindings. Becomes part of the Wasm changelog
Milestone

Comments

@chrisgitiota
Copy link

The folder iota_sdk_abstraction/types contains a subset of the code, used as a wasm32 compatible replacement for the IOTA Client Rust SDK.

The sources in iota_sdk_abstraction/types are currently outdated. The latest state of IOTA Client Rust SDK needs to be cherrypicked and manually merged into iota_sdk_abstraction/types. As only some parts of the Rust SDK code are used in iota_sdk_abstraction/types the code needs to be compared file by file and only changes that apply to code already existing in iota_sdk_abstraction/types shall be merged.

Before doing the upstream merging, we need to consent on a pinned version for the Rust and Typescript IOTA Client SDK.

@chrisgitiota chrisgitiota added Rust Related to the core Rust code. Becomes part of the Rust changelog. Wasm Related to Wasm bindings. Becomes part of the Wasm changelog labels Nov 25, 2024
@chrisgitiota chrisgitiota added this to the Wasm Rebased milestone Nov 25, 2024
@eike-hass eike-hass modified the milestones: Wasm Rebased, v1.6 Dec 9, 2024
@eike-hass eike-hass moved this from Product Backlog to Sprint Backlog in IOTA Trust Framework Developments Jan 6, 2025
@wulfraem
Copy link
Contributor

wulfraem commented Jan 22, 2025

If it helps: a currently known issue, which will be fixed with this PR, is that our interaction types still use the hasPublicTransfer field. This has been removed from the iota crate.

Currently testing locally with these fields commented out in:

  • identity_iota_interaction/src/sdk_types/iota_json_rpc_types/iota_object.rs -> IotaParsedMoveObject
  • identity_iota_interaction/src/sdk_types/iota_json_rpc_types/iota_object.rs -> IotaRawMoveObject

With the fields commented out, parsing of results from node works again. ^^

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Rust Related to the core Rust code. Becomes part of the Rust changelog. Wasm Related to Wasm bindings. Becomes part of the Wasm changelog
Projects
Development

No branches or pull requests

3 participants