Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: Angular HMR not working within ion-router-outlet #30105

Open
3 tasks done
co-dax opened this issue Dec 28, 2024 · 0 comments
Open
3 tasks done

bug: Angular HMR not working within ion-router-outlet #30105

co-dax opened this issue Dec 28, 2024 · 0 comments
Labels

Comments

@co-dax
Copy link

co-dax commented Dec 28, 2024

Prerequisites

Ionic Framework Version

v8.x

Current Behavior

Angular hot module replacement does not work inside ion-router-outlet but it does work inside router-outlet but in that case Ionic life cycle events inherent to ion-router-outlet (ionViewWillEnter, ionViewDidEnter, etc...) are not being fired when hmr occurs (which is normal these event are only part of ion-router-outlet).
The same issue has already been reported in Angular repository at angular/angular#59243 with a link to a code reproduction url at https://github.com/ReneZeidler/hmr-ionic-bug, however it is also enough to create a new Ionic project and just make a change within a component inside ion-router-outlet to reproduce the issue.

Expected Behavior

Angular hot module replacement should work inside ion-router-outlet.

Steps to Reproduce

Refer to angular/angular#59243

Code Reproduction URL

https://github.com/ReneZeidler/hmr-ionic-bug

Ionic Info

Ionic:

Ionic CLI : 7.2.0

Utility:

cordova-res : 0.15.4
native-run : not installed globally

System:

NodeJS : v20.10.0
npm : 10.2.3
OS : Windows 10

Additional Information

No response

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant