-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AdMob docs are messy, have broken links and include/promote money stealing plugin #698
Comments
V4The As for AdMob-Pro, I wouldn't really say that this is "stealing" money, as they clearly state that it is a commercial plugin. I think we could modify the docs to add back the "Paid" flag in the menu and make the note that it is a paid plugin a bit clearer. V3You are correct here! We'll get this cleaned up. Thanks for the issue 😄 |
nope, it redirects to one, the exact link doesnt exist, if you click on "Admob" on the menu you get a "uh oh" page. Yes that plugin steals from developers. You can see my full documentation here but in short: if I tell you: hey you got to pay a $20 licence or I get 2% of your revenue and then I'm secretly controlling your ads with my server side code and actually taking 30% without ever telling you or disclosing that anywhere or putting it in the license, and trying to hide that by disabling issues, isnt that stealing? (taking 30% without prier agreement!) |
You might not call it "stealing" but if the ionic team wants to promote a plugin with server side control over ads that's up to you guys. |
the admob-pro has a message now explaining that anyway, plugin docs come from awesome-cordova-plugins, you can report issues there https://github.com/danielsogl/awesome-cordova-plugins/issues |
URL
(URLs bellow)
What is missing or inaccurate about the content on this page?
The current docs as well as the V3 docs have multiple AdMob pages (some invalid) and include/promote a plugin that steals money from developers (
cordova-plugin-admob
orcordova-plugin-admobpro
)I propose you remove this pages (and the associated modules code):
![image](https://user-images.githubusercontent.com/1134310/57851957-c9dfb280-77d9-11e9-9182-d82f2a7e3b6f.png)
V4 docs
https://ionicframework.com/docs/native/admob (non existent) (but linked in the menu)
https://ionicframework.com/docs/native/admob-pro (money stealing plugin) (module: @ionic-native/admob-pro/ngx)
V3 docs:
https://ionicframework.com/docs/v3/native/admob-pro/ (module: @ionic-native/admob-pro)
"AdMob" and "Admob" is repeated and redirects to "AdMob-Pro" (see image bellow)
The text was updated successfully, but these errors were encountered: