Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Codecov migration to marketplace app #86

Open
thomasrockhu opened this issue Jun 1, 2020 · 12 comments
Open

Codecov migration to marketplace app #86

thomasrockhu opened this issue Jun 1, 2020 · 12 comments

Comments

@thomasrockhu
Copy link

Hi, Tom from Codecov here.

We noticed that you are using Codecov with fairly high frequency, and we’re so excited to see that! However, because you are not using our app, you may have experienced issues with uploading reports or viewing coverage information. This is due to rate-limiting issues from GitHub.

In order to prevent any future outages, we ask that you move over to our GitHub app integration.

The process is extremely simple and shouldn’t require more than a few clicks, and you should not expect any downtime. By moving to our app, you will no longer need an admin or separate account to manage the relationship with GitHub as the team bot.

Let me know if you have any questions, or if I can help at all with this process.

@ionelmc
Copy link
Owner

ionelmc commented Jun 1, 2020

So I pressed some Yes buttons from that link - is the new integration active?

@thomasrockhu
Copy link
Author

Hi @ionelmc, it looks active for many of your repositories, but not actually for this one.

@ionelmc
Copy link
Owner

ionelmc commented Jun 1, 2020

Ok so I see this:

GitHub Integration is installed. However, this repository is not enabled.

Click here to your installation listings
Find Repository access and add python-hunter to the list.

May take a couple minutes for our system to get notices of new projects added.

Can't see where is this "Repository access". I have granted codecov access to all my repos. Maybe there's a bug somewhere?

@ionelmc
Copy link
Owner

ionelmc commented Jun 2, 2020

@thomasrockhu so I've did the per repo integration and now everything shows ok. However I have many repos and I'd like to avoid manual work. Pretty sure there's a bug in your system - it should do whatever is necessary automatically - I have already granted codecov access to everything.

@thomasrockhu
Copy link
Author

Hi @ionelmc, I believe this is a restriction with GitHub. However, you should have been able to select All repositories if that was an issue.

image

@ionelmc
Copy link
Owner

ionelmc commented Jun 3, 2020

I can select "All repositories" and it doesn't actually work. That's what I've been trying to tell :)

@thomasrockhu
Copy link
Author

@ionelmc that is really strange. I just revoked my own permissions and added the integration, while being able to click All repositories. What's the error you're seeing? Is it that you can't click All repositories, or that you can't click Save, or that after Save, there is no change?

@ionelmc
Copy link
Owner

ionelmc commented Jun 3, 2020

I don't see it integrated until I use "Only select repositories" and pick the repo from the list.

This is what I get if I don't do that (check https://codecov.io/gh/ionelmc/python-lazy-object-proxy/ for instance):

image

@thomasrockhu
Copy link
Author

Thanks for the details here @ionelmc. I'm not sure why this is happening for you, but I'll loop in the product team. This might be an issue with GitHub, as well.

@thomasrockhu
Copy link
Author

@ionelmc, the only thing I can think to try is

  • sign out of codecov.io
  • remove all codecov cookies
  • sign back in
  • re-sync repositories on the codecov.io/gh page
  • try to select all repositories again

If the issue persists, I'll escalate to the GitHub team

@ionelmc
Copy link
Owner

ionelmc commented Jun 3, 2020

I've just tried that in a private window. It doesn't have any effect, python-lazy-object-proxy still shows as not "enabled", whatever that means. Your proposal doesn't make sense anyway, why would cookies have any effect on your broken github integration.

@thomasrockhu
Copy link
Author

@ionelmc, thanks for trying, I really appreciate it. I've reached out to GitHub to see why this is broken for you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants